From mboxrd@z Thu Jan 1 00:00:00 1970 From: "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" Subject: Re: [PATCH] Documentation/Intel-IOMMU.txt: Modify definition of DRHD Date: Tue, 25 Aug 2015 10:51:48 +0200 Message-ID: <20150825085148.GC32055@8bytes.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Xiao, Nan (Nan@HPS Performance, Beijing)" Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" List-Id: iommu@lists.linux-foundation.org Hi Nan, I applied this patch with some formatting fixes, thanks. Details below: From: "Xiao, Nan (Nan@HPS Performance, Beijing)" git-am made this author-line out of your patch: "(Nan@HPS <(Nan@HPS>" Which doesn't even look like a valid email address. I fixed it, but please include a From: line in your future patches like this: From: Xiao, Nan This will guarantee that your patches will be accounted correctly. Next is the patch subject. For iommu patches please use a prefix like this: / In case of Intel VT-d this would look like "iommu/vt-d:", and my updated subject line looks like: Subject: x86/vt-d: Fix documentation of DRHD On Mon, Aug 24, 2015 at 06:22:42AM +0000, Xiao, Nan (Nan@HPS Performance, Beijing) wrote: > According to "Intel Virtualization Technology for Directed I/O" specification, > DRHD stands for "DMA Remapping Hardware Unit Definition" , not "DMA Engine Reporting Structure". These lines are too long. Please try to limit the line-length in patches to 60 characters for iommu patches. Thanks, Joerg