From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Change default tftp timeout to be rfc-compliant
Date: Tue, 25 Aug 2015 13:44:25 +0200 [thread overview]
Message-ID: <20150825114425.GA16939@amd> (raw)
In-Reply-To: <CAEUhbmXywZuAe9rQMiDpHaAS2O6K8gSwhM1CSckmGUNyb_qhVQ@mail.gmail.com>
tftp timeout of 100msec gives good performance on local ethernet, but
some servers (Centos) refuse to operate, and it is against RFC 2349.
This fixes regression caused by
620776d734e4b126c407f636bda825a594a17723 .
Signed-off-by: Pavel Machek <pavel@denx.de>
diff --git a/net/tftp.c b/net/tftp.c
index 18ce84c..e919638 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -18,8 +18,9 @@
/* Well known TFTP port # */
#define WELL_KNOWN_PORT 69
-/* Millisecs to timeout for lost pkt */
-#define TIMEOUT 100UL
+/* Millisecs to timeout for lost pkt. Anything below 1000msec is against RFC, and
+ some servers will refuse it. */
+#define TIMEOUT 1000UL
#ifndef CONFIG_NET_RETRY_COUNT
/* # of timeouts before giving up */
# define TIMEOUT_COUNT 1000
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-08-25 11:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 2:25 [U-Boot] commit 620776d causes TFTP error: 'Unsupported option(s) requested' (8) Bin Meng
2015-08-25 3:42 ` Joe Hershberger
2015-08-25 4:05 ` Bin Meng
2015-08-25 4:24 ` Joe Hershberger
2015-08-25 7:40 ` Bin Meng
2015-08-25 12:13 ` Hannes Schmelzer
2015-08-25 12:19 ` Pavel Machek
2015-08-25 12:23 ` Hannes Schmelzer
2015-09-10 22:26 ` Alexey Brodkin
2015-09-10 22:46 ` Joe Hershberger
2015-09-10 22:51 ` Simon Glass
2015-08-25 7:12 ` Pavel Machek
2015-08-25 8:58 ` Bin Meng
2015-08-25 9:22 ` Bin Meng
2015-08-25 11:28 ` Pavel Machek
2015-08-25 11:44 ` Pavel Machek [this message]
2015-08-25 13:03 ` [U-Boot] [PATCH] Change default tftp timeout to be rfc-compliant Bin Meng
2015-08-25 14:32 ` Pavel Machek
2015-08-25 14:49 ` Tom Rini
2015-08-25 15:33 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825114425.GA16939@amd \
--to=pavel@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.