From: Christoph Hellwig <hch@infradead.org>
To: Tomas Henzl <thenzl@redhat.com>
Cc: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>,
JBottomley@Parallels.com, linux-scsi@vger.kernel.org,
aacraid@pmc-sierra.com, Harry.Yang@pmcs.com, Rich.Bono@pmcs.com
Subject: Re: [PATCH V6 08/10] [SCSI] aacraid: Send commit-config to controller firmware
Date: Tue, 25 Aug 2015 08:11:14 -0700 [thread overview]
Message-ID: <20150825151114.GA25134@infradead.org> (raw)
In-Reply-To: <55DC8256.4060102@redhat.com>
On Tue, Aug 25, 2015 at 04:57:26PM +0200, Tomas Henzl wrote:
> On 11.8.2015 07:58, Mahesh Rajashekhara wrote:
> > +#if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__)
> > + aac_get_config_status(aac, 1);
> > +#else
> > aac_get_config_status(aac, 0);
> > +#endif
>
> If we use instead
> + aac_get_config_status(aac, 1);
> on all archs will it make problems ?
Yes, that should be our first choice. If that doesn't work it should
be a #ifndef CONFIG_X86 with a comment explaining it.
next prev parent reply other threads:[~2015-08-25 15:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 5:58 [PATCH V6 00/10] [SCSI] aacraid: Patchset for aacraid driver version 41010 Mahesh Rajashekhara
2015-08-11 5:58 ` [PATCH V6 01/10] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS Mahesh Rajashekhara
2015-08-25 6:26 ` Karthikeya Sunkesula
2015-08-25 7:06 ` Murthy Bhat
2015-08-25 13:39 ` Tomas Henzl
2015-08-11 5:58 ` [PATCH V6 02/10] [SCSI] aacraid: Add Power Management support Mahesh Rajashekhara
2015-08-25 6:26 ` Karthikeya Sunkesula
2015-08-25 7:06 ` Murthy Bhat
2015-08-25 13:41 ` Tomas Henzl
2015-08-11 5:58 ` [PATCH V6 03/10] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller Mahesh Rajashekhara
2015-08-25 6:26 ` Karthikeya Sunkesula
2015-08-25 7:06 ` Murthy Bhat
2015-08-25 13:50 ` Tomas Henzl
2015-08-11 5:58 ` [PATCH V6 04/10] [SCSI] aacraid: Enable 64-bit write to controller register Mahesh Rajashekhara
2015-08-25 6:27 ` Karthikeya Sunkesula
2015-08-25 7:06 ` Murthy Bhat
2015-08-25 13:51 ` Tomas Henzl
2015-08-11 5:58 ` [PATCH V6 05/10] [SCSI] aacraid: Tune response path if IsFastPath bit set Mahesh Rajashekhara
2015-08-25 6:28 ` Karthikeya Sunkesula
2015-08-25 7:07 ` Murthy Bhat
2015-08-11 5:58 ` [PATCH V6 06/10] [SCSI] aacraid: Reset irq affinity hints before releasing irq Mahesh Rajashekhara
2015-08-25 6:28 ` Karthikeya Sunkesula
2015-08-25 7:07 ` Murthy Bhat
2015-08-25 14:48 ` Tomas Henzl
2015-08-11 5:58 ` [PATCH V6 07/10] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend Mahesh Rajashekhara
2015-08-25 6:29 ` Karthikeya Sunkesula
2015-08-25 7:07 ` Murthy Bhat
2015-08-25 14:49 ` Tomas Henzl
2015-08-11 5:58 ` [PATCH V6 08/10] [SCSI] aacraid: Send commit-config to controller firmware Mahesh Rajashekhara
2015-08-25 6:29 ` Karthikeya Sunkesula
2015-08-25 7:07 ` Murthy Bhat
2015-08-25 14:57 ` Tomas Henzl
2015-08-25 15:11 ` Christoph Hellwig [this message]
2015-08-27 10:46 ` Mahesh Rajashekhara
2015-08-11 5:58 ` [PATCH V6 09/10] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range() Mahesh Rajashekhara
2015-08-25 6:29 ` Karthikeya Sunkesula
2015-08-25 7:11 ` Murthy Bhat
2015-08-25 15:06 ` Tomas Henzl
2015-08-11 5:58 ` [PATCH V6 10/10] [SCSI] aacraid: Update driver version Mahesh Rajashekhara
2015-08-25 6:30 ` Karthikeya Sunkesula
2015-08-25 7:11 ` Murthy Bhat
2015-08-25 15:07 ` Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825151114.GA25134@infradead.org \
--to=hch@infradead.org \
--cc=Harry.Yang@pmcs.com \
--cc=JBottomley@Parallels.com \
--cc=Mahesh.Rajashekhara@pmcs.com \
--cc=Rich.Bono@pmcs.com \
--cc=aacraid@pmc-sierra.com \
--cc=linux-scsi@vger.kernel.org \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.