From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUHTH-0006ZZ-9X for qemu-devel@nongnu.org; Tue, 25 Aug 2015 12:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUHT8-00067q-FK for qemu-devel@nongnu.org; Tue, 25 Aug 2015 12:53:09 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:55009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUHT8-00067Q-85 for qemu-devel@nongnu.org; Tue, 25 Aug 2015 12:53:06 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Aug 2015 10:53:05 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id A42911FF004A for ; Tue, 25 Aug 2015 10:42:23 -0600 (MDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7PGoVrd41877564 for ; Tue, 25 Aug 2015 09:50:31 -0700 Received: from d03av05.boulder.ibm.com (localhost [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7PGpDfm020696 for ; Tue, 25 Aug 2015 10:51:14 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1435751267-26378-5-git-send-email-marcandre.lureau@gmail.com> References: <1435751267-26378-1-git-send-email-marcandre.lureau@gmail.com> <1435751267-26378-5-git-send-email-marcandre.lureau@gmail.com> Message-ID: <20150825155502.11069.59278@loki> Date: Tue, 25 Aug 2015 10:55:02 -0500 Subject: Re: [Qemu-devel] [PATCH 04/12] qga: rename 'path' to 'device_path' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , qemu-devel@nongnu.org Quoting Marc-Andr=C3=A9 Lureau (2015-07-01 06:47:39) > 'path' is already a global function, rename the variable since it's > going to be in global scope in a later patch. > = > Signed-off-by: Marc-Andr=C3=A9 Lureau I think I'd prefer something like 'channel_path' since we support sockets as well. Looks good otherwise. > --- > qga/main.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > = > diff --git a/qga/main.c b/qga/main.c > index 0c455f8..1c81575 100644 > --- a/qga/main.c > +++ b/qga/main.c > @@ -944,7 +944,7 @@ static GList *split_list(gchar *str, const gchar sepa= rator) > int main(int argc, char **argv) > { > const char *sopt =3D "hVvdm:p:l:f:F::b:s:t:"; > - const char *method =3D NULL, *path =3D NULL; > + const char *method =3D NULL, *device_path =3D NULL; > const char *log_filepath =3D NULL; > const char *pid_filepath; > #ifdef CONFIG_FSFREEZE > @@ -990,7 +990,7 @@ int main(int argc, char **argv) > method =3D optarg; > break; > case 'p': > - path =3D optarg; > + device_path =3D optarg; > break; > case 'l': > log_filepath =3D optarg; > @@ -1040,7 +1040,8 @@ int main(int argc, char **argv) > if (ga_install_vss_provider()) { > exit(EXIT_FAILURE); > } > - if (ga_install_service(path, log_filepath, fixed_state_d= ir)) { > + if (ga_install_service(device_path, log_filepath, > + fixed_state_dir)) { > exit(EXIT_FAILURE); > } > exit(EXIT_SUCCESS); > @@ -1185,7 +1186,7 @@ int main(int argc, char **argv) > #endif > = > s->main_loop =3D g_main_loop_new(NULL, false); > - if (!channel_init(ga_state, method, path)) { > + if (!channel_init(ga_state, method, device_path)) { > g_critical("failed to initialize guest agent channel"); > goto out_bad; > } > -- = > 2.4.3 >=20