From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 25 Aug 2015 12:06:05 -0400 Subject: [U-Boot] [PATCH] omap-common: SYS_BOOT fallback logic correction In-Reply-To: <1440517253-18394-1-git-send-email-contact@paulk.fr> References: <1440517253-18394-1-git-send-email-contact@paulk.fr> Message-ID: <20150825160605.GP25532@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 25, 2015 at 05:40:53PM +0200, Paul Kocialkowski wrote: > The SYS_BOOT-based fallback shouldn't only check for one of the conditions of > use and then let the switch/case handle each boot device without enforcing the > conditions for each type of boot device again. > > For instance, this behaviour would trigger the fallback for UART when > BOOT_DEVICE_UART is defined, CONFIG_SPL_YMODEM_SUPPORT is enabled (which should > be a show-stopper) and e.g. BOOT_DEVICE_USB is enabled and not > CONFIG_SPL_USB_SUPPORT. > Separating the logic for USB and UART is a first step to solve this. > > In addition, a similar problematic behaviour took place when BOOT_DEVICE_USBETH, > BOOT_DEVICE_USB and CONFIG_SPL_USBETH_SUPPORT were enabled and not > CONFIG_SPL_USB_SUPPORT. > > Since BOOT_DEVICE_USBETH is only a problem when it's defined to the same value > as BOOT_DEVICE_USB, we can check that BOOT_DEVICE_USBETH and BOOT_DEVICE_USB are > different and if not, that CONFIG_SPL_USBETH_SUPPORT is not enabled to enable > the SYS_BOOT-based fallback mechanism. > > Signed-off-by: Paul Kocialkowski Reviewed-by: Tom Rini But I'm going to wait until Hannes can report back with a Tested-by too, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: