All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Justin Chen <justinpopo6@gmail.com>
Cc: linux-kernel@vger.kernel.org, feedback-list@broadcom.com,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	wim@iguana.be, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation
Date: Tue, 25 Aug 2015 12:04:48 -0700	[thread overview]
Message-ID: <20150825190448.GA29547@roeck-us.net> (raw)
In-Reply-To: <20150825175538.GA16266@Justins-MacBook-Pro.local>

Justin,

On Tue, Aug 25, 2015 at 10:55:40AM -0700, Justin Chen wrote:
> 
> Hello Guenter,
> 
> > Is 'clock-frequency' really needed (and useful), or would it make more sense
> > to expect the user to configure a fixed clock if nothing else is available ?
> > How do other drivers handle this ?
> 
> The reason for 'clock-frequency' was for a case where our device tree did not
> have clocks. Creating a new fixed clock for a single device seems unnecessary
> compared to a 'clock-frequency' property. Their is a use for 'clock-frequency',
> but it is not really necessary. However, this is my first linux patch, so I do 
> not fully trust my judgement on this...
> 

All that is needed for a fixed clock is a devicetree entry for it. Not sure
I understand your line of argument; you add a lot of complexity and code
just to avoid those few lines in the dts file (especially with 500+
"fixed-clock" nodes in other devicetree files).

Thanks,
Guenter

  reply	other threads:[~2015-08-25 19:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 17:41 [PATCH 0/2] watchdog: driver for BCM7038 and newer chips Justin Chen
2015-08-20 17:41 ` Justin Chen
2015-08-20 17:41 ` [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation Justin Chen
2015-08-20 17:41   ` Justin Chen
2015-08-24  3:32   ` Guenter Roeck
2015-08-24  3:32     ` Guenter Roeck
2015-08-25 17:55     ` Justin Chen
2015-08-25 17:55       ` Justin Chen
2015-08-25 19:04       ` Guenter Roeck [this message]
2015-08-25 19:40         ` Justin Chen
2015-08-25 19:40           ` Justin Chen
2015-08-20 17:41 ` [PATCH 2/2] watchdog: Watchdog driver for Broadcom Set-Top Box Justin Chen
2015-08-20 17:41   ` Justin Chen
2015-08-24  3:29   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825190448.GA29547@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=devicetree@vger.kernel.org \
    --cc=feedback-list@broadcom.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=justinpopo6@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.