From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUM57-0000Bt-1W for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUM52-0005dH-Ox for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:48:36 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:57802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUM52-0005dA-IA for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:48:32 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Aug 2015 15:48:31 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 86CBF3E4003B for ; Tue, 25 Aug 2015 15:48:29 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7PLlkcX50069736 for ; Tue, 25 Aug 2015 14:47:46 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7PLmTJY002352 for ; Tue, 25 Aug 2015 15:48:29 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1438624464-22770-4-git-send-email-leonid@daynix.com> References: <1438624464-22770-1-git-send-email-leonid@daynix.com> <1438624464-22770-4-git-send-email-leonid@daynix.com> Message-ID: <20150825214825.11069.67802@loki> Date: Tue, 25 Aug 2015 16:48:25 -0500 Subject: Re: [Qemu-devel] [PATCH v3 3/4] qemu-ga: Created a separate component for each installed file in the MSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Bloch , qemu-devel@nongnu.org Cc: marcandre.lureau@gmail.com Quoting Leonid Bloch (2015-08-03 12:54:23) > This is done to follow the recommendations given here: https://msdn.micro= soft.com/en-us/library/aa368269%28VS.85%29.aspx > = > Signed-off-by: Leonid Bloch > --- > qga/installer/qemu-ga.wxs | 47 ++++++++++++++++++++++++++++++++++++-----= ------ > 1 file changed, 36 insertions(+), 11 deletions(-) > = > diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs > index dac1df0..2302745 100644 > --- a/qga/installer/qemu-ga.wxs > +++ b/qga/installer/qemu-ga.wxs > @@ -71,16 +71,6 @@ > > > > - > - > - > - > - > - > - > - > - > - > Id=3D"ServiceInstaller" > Type=3D"ownProcess" > @@ -97,7 +87,32 @@ > > > > - > + > + > + Is there a reason these paths are seemingly relative to qga/installer/qemu-ga.wxs? I'd imagine that works for running wixl command within that directly, but top-level Makefile 'msi' ends up bombing if I do 'make msi': [mdroth@vm4 qemu-build-w64]$ ../w/qemu4.git/configure --cross-prefix=3Dx86_= 64-w64-mingw32- \ --with-vss-sdk=3D/home/mdroth/w/vss-win32/ --target-list=3Dx86_64-softmmu --extra-cflags=3D-Wall --enable-guest-agent --enable-guest-agent-msi ... [mdroth@vm4 qemu-build-w64]$ make -j4 qemu ... CC trace/generated-events.o AR libqemustub.a CC qemu-img.o CC qmp-marshal.o AR libqemuutil.a LINK qemu-ga.exe LINK qemu-img.exe LINK qemu-io.exe ... [mdroth@vm4 qemu-build-w64]$ make msi LEX convert-dtsv0-lexer.lex.c make[1]: flex: Command not found BISON dtc-parser.tab.c make[1]: bison: Command not found LEX dtc-lexer.lex.c make[1]: flex: Command not found WIXL qemu-ga-x86_64.msi Couldn't find file ../../qemu-ga.exe make: *** [qemu-ga-x86_64.msi] Error 1 The fix seems simple enough, but I want to make sure I'm not doing something stupid and have some idea of how people are using the current MSI installer code.