From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUMFE-0006xe-DR for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:59:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUMFB-0002zr-5s for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:59:04 -0400 Received: from e18.ny.us.ibm.com ([129.33.205.208]:33213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUMFB-0002zf-01 for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:59:01 -0400 Received: from /spool/local by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Aug 2015 17:59:00 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 6912A38C8039 for ; Tue, 25 Aug 2015 17:58:57 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7PLwv2I38666410 for ; Tue, 25 Aug 2015 21:58:57 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7PLwuUT008830 for ; Tue, 25 Aug 2015 17:58:57 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <20150825214825.11069.67802@loki> References: <1438624464-22770-1-git-send-email-leonid@daynix.com> <1438624464-22770-4-git-send-email-leonid@daynix.com> <20150825214825.11069.67802@loki> Message-ID: <20150825215852.11069.62811@loki> Date: Tue, 25 Aug 2015 16:58:52 -0500 Subject: Re: [Qemu-devel] [PATCH v3 3/4] qemu-ga: Created a separate component for each installed file in the MSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Bloch , qemu-devel@nongnu.org Cc: marcandre.lureau@gmail.com Quoting Michael Roth (2015-08-25 16:48:25) > Quoting Leonid Bloch (2015-08-03 12:54:23) > > This is done to follow the recommendations given here: https://msdn.mic= rosoft.com/en-us/library/aa368269%28VS.85%29.aspx > > = > > Signed-off-by: Leonid Bloch > > --- > > qga/installer/qemu-ga.wxs | 47 ++++++++++++++++++++++++++++++++++++---= -------- > > 1 file changed, 36 insertions(+), 11 deletions(-) > > = > > diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs > > index dac1df0..2302745 100644 > > --- a/qga/installer/qemu-ga.wxs > > +++ b/qga/installer/qemu-ga.wxs > > @@ -71,16 +71,6 @@ > > > > > > > > - > > - > > - > > - > > - > > - > > - > > - > > - > > - > > > Id=3D"ServiceInstaller" > > Type=3D"ownProcess" > > @@ -97,7 +87,32 @@ > > > > > > > > - > > + > > + > > + > = > Is there a reason these paths are seemingly relative to > qga/installer/qemu-ga.wxs? I'd imagine that works for running wixl > command within that directly, but top-level Makefile 'msi' ends up *'msi' target *within that directory > bombing if I do 'make msi': > = > [mdroth@vm4 qemu-build-w64]$ ../w/qemu4.git/configure --cross-prefix=3Dx8= 6_64-w64-mingw32- \ > --with-vss-sdk=3D/home/mdroth/w/vss-win32/ --target-list=3Dx86_64-softm= mu > --extra-cflags=3D-Wall --enable-guest-agent --enable-guest-agent-msi > ... > = > [mdroth@vm4 qemu-build-w64]$ make -j4 qemu `make -j4` was the command, not sure how that 'qemu' slipped in. > ... > CC trace/generated-events.o > AR libqemustub.a > CC qemu-img.o > CC qmp-marshal.o > AR libqemuutil.a > LINK qemu-ga.exe > LINK qemu-img.exe > LINK qemu-io.exe > ... > = > [mdroth@vm4 qemu-build-w64]$ make msi > LEX convert-dtsv0-lexer.lex.c > make[1]: flex: Command not found > BISON dtc-parser.tab.c > make[1]: bison: Command not found > LEX dtc-lexer.lex.c > make[1]: flex: Command not found > WIXL qemu-ga-x86_64.msi > Couldn't find file ../../qemu-ga.exe > make: *** [qemu-ga-x86_64.msi] Error 1 > = > The fix seems simple enough, but I want to make sure I'm not doing someth= ing > stupid and have some idea of how people are using the current MSI install= er > code. > = >=20