From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: broonie@kernel.org, linaro-kernel@lists.linaro.org, nm@ti.com,
Liam Girdwood <lgirdwood@gmail.com>,
"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3] regulator: core: Define regulator_set_voltage_triplet()
Date: Tue, 25 Aug 2015 15:53:45 -0700 [thread overview]
Message-ID: <20150825225345.GM19120@codeaurora.org> (raw)
In-Reply-To: <5f42eb06c47a316cd7138e4f75a4176eea4fb202.1439779404.git.viresh.kumar@linaro.org>
On 08/17, Viresh Kumar wrote:
> Voltage tolerance isn't necessarily same on both sides of the target
> voltage and regulator_set_voltage_tol() wouldn't be suitable in such
> cases.
>
> Add another routine regulator_set_voltage_triplet(), which accepts
> target, min and max voltages as arguments.
>
> This first tries to set the voltage between the target voltage and the
> upper limit, then fall back on the full range. The idea behind this is
> to set regulator's voltage as close to the target voltage, as possible.
>
> Based on regulator_set_voltage_tol().
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Looks good to me.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-08-25 22:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 2:46 [PATCH V3] regulator: core: Define regulator_set_voltage_triplet() Viresh Kumar
2015-08-25 22:53 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825225345.GM19120@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.