From: Darren Hart <dvhart@infradead.org>
To: Qipeng Zha <qipeng.zha@intel.com>
Cc: platform-driver-x86@vger.kernel.org, fei.yang@intel.com,
huiquan.zhong@intel.com, jason.cj.chen@intel.com,
qi.zheng@intel.com
Subject: Re: [PATCH v2] platform:x86: add Intel P-Unit mailbox IPC driver
Date: Wed, 26 Aug 2015 00:36:20 -0700 [thread overview]
Message-ID: <20150826073620.GA105700@vmdeb7> (raw)
In-Reply-To: <1440176659-83769-1-git-send-email-qipeng.zha@intel.com>
On Sat, Aug 22, 2015 at 01:04:19AM +0800, Qipeng Zha wrote:
> This driver provides support for P-Unit mailbox IPC on Intel platforms.
> The heart of the P-Unit is the Foxton microcontroller and its firmware,
> which provide mailbox interface for power management usage.
>
> Signed-off-by: Qipeng Zha <qipeng.zha@intel.com>
Hi Qipeng,
0-day/lkp raised a couple of issues please review that report.
I immediately hit a build failure:
$ make allmodconfig
$ make drivers/platform/x86/intel_punit_ipc.ko
CC drivers/platform/x86/intel_punit_ipc.o
In file included from drivers/platform/x86/intel_punit_ipc.c:20:0:
./arch/x86/include/asm/intel_punit_ipc.h:87:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘int’
static intline int intel_punit_ipc_simple_command(int cmd,
^
./arch/x86/include/asm/intel_punit_ipc.h:89:1: error: expected identifier or ‘(’ before ‘{’ token
{
^
./arch/x86/include/asm/intel_punit_ipc.h:95:1: error: expected identifier or ‘(’ before ‘{’ token
{
^
scripts/Makefile.build:258: recipe for target 'drivers/platform/x86/intel_punit_ipc.o' failed
make[1]: *** [drivers/platform/x86/intel_punit_ipc.o] Error 1
Makefile:1550: recipe for target 'drivers/platform/x86/intel_punit_ipc.ko' failed
make: *** [drivers/platform/x86/intel_punit_ipc.ko] Error 2
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-08-26 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 17:04 [PATCH v2] platform:x86: add Intel P-Unit mailbox IPC driver Qipeng Zha
2015-08-26 7:36 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826073620.GA105700@vmdeb7 \
--to=dvhart@infradead.org \
--cc=fei.yang@intel.com \
--cc=huiquan.zhong@intel.com \
--cc=jason.cj.chen@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qi.zheng@intel.com \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.