From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: Peng Sun <sironhide0null@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis
Date: Wed, 26 Aug 2015 12:29:01 +0300 [thread overview]
Message-ID: <20150826092901.GA17922@ghost> (raw)
In-Reply-To: <1440561137-15574-4-git-send-email-sironhide0null@gmail.com>
On Wed, Aug 26, 2015 at 11:52:12AM +0800, Peng Sun wrote:
> Signed-off-by: Peng Sun <sironhide0null@gmail.com>
Please always add a changelog message. Also, you need to fix the subject. The
convention is to use something like: "a: b: ..."
So in this case it should be something like: "staging: android: ..."
You can look at `git log drivers/staging/android` for inspiration. This applies
to all of your other patches as well. Finally, I don't think there is a point
in using deep threading in this case.
next prev parent reply other threads:[~2015-08-26 9:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 3:52 [PATCH 0/8] fix drivers/staging/android several coding style issues Peng Sun
2015-08-26 3:52 ` [PATCH 1/8] fix staging:android style issue:spaces preferred around that '-' Peng Sun
2015-08-26 3:52 ` [PATCH 2/8] fix staging:android style issue:No space is necessary after a cast Peng Sun
2015-08-26 3:52 ` [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis Peng Sun
2015-08-26 3:52 ` [PATCH 4/8] fix staging:android style issue:Prefer kernel type 'u32' over 'uint32_t' Peng Sun
2015-08-26 3:52 ` [PATCH 5/8] fix staging:android style issue:Please use a blank line after function/struct/union/enum declarations Peng Sun
2015-08-26 3:52 ` [PATCH 6/8] fix staging:android style issue:Comparison to NULL could be written Peng Sun
2015-08-26 3:52 ` [PATCH 7/8] fix staging:android style issue:definition without comment Peng Sun
2015-08-26 3:52 ` [PATCH 8/8] fix staging:android style issue:Please don't use multiple blank lines Peng Sun
2015-08-26 9:29 ` Giedrius Statkevičius [this message]
2015-09-03 1:05 ` [PATCH 0/8] fix drivers/staging/android several coding style issues Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826092901.GA17922@ghost \
--to=giedrius.statkevicius@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sironhide0null@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.