From: Gustavo Padovan <gustavo@padovan.org>
To: linux-samsung-soc@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
jy0922.shim@samsung.com, tjakobi@math.uni-bielefeld.de,
daniel@ffwll.ch,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH 1/2] drm/exynos: remove legacy ->suspend()/resume()
Date: Wed, 26 Aug 2015 12:50:44 -0300 [thread overview]
Message-ID: <20150826155044.GC1991@joana> (raw)
In-Reply-To: <1439496399-25791-1-git-send-email-gustavo@padovan.org>
Hi,
What about this patch? We need it to avoid the WARN_ON added by patch
2/2 that was already picked up by Daniel.
Gustavo
2015-08-13 Gustavo Padovan <gustavo@padovan.org>:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> These legacy helpers should only be used by shadow-attaching drivers.
> KMS drivers has its own way to handle suspend/resume and don't need to
> use these two helpers.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index f1d6966..9bcf679 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -280,8 +280,6 @@ static struct drm_driver exynos_drm_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME,
> .load = exynos_drm_load,
> .unload = exynos_drm_unload,
> - .suspend = exynos_drm_suspend,
> - .resume = exynos_drm_resume,
> .open = exynos_drm_open,
> .preclose = exynos_drm_preclose,
> .lastclose = exynos_drm_lastclose,
> --
> 2.1.0
>
next prev parent reply other threads:[~2015-08-26 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 20:06 [PATCH 1/2] drm/exynos: remove legacy ->suspend()/resume() Gustavo Padovan
2015-08-13 20:06 ` [PATCH 2/2] drm: WARN_ON if a modeset driver uses legacy suspend/resume helpers Gustavo Padovan
2015-08-13 21:19 ` Daniel Vetter
2015-08-26 15:50 ` Gustavo Padovan [this message]
2015-08-26 19:12 ` [PATCH 1/2] drm/exynos: remove legacy ->suspend()/resume() Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826155044.GC1991@joana \
--to=gustavo@padovan.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.