From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:34582 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754238AbbHZQhL (ORCPT ); Wed, 26 Aug 2015 12:37:11 -0400 Date: Wed, 26 Aug 2015 18:36:33 +0200 From: David Sterba To: "Darrick J. Wong" Cc: Peng Tao , linux-fsdevel@vger.kernel.org, Trond Myklebust , Anna Schumaker , Christoph Hellwig , Zach Brown , Darren Hart , bfields@fieldses.org, Jeff Layton , linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH-RFC-RESEND 1/9] vfs: pull btrfs clone API to vfs layer Message-ID: <20150826163633.GC10756@suse.cz> Reply-To: dsterba@suse.cz References: <1440577010-122867-1-git-send-email-tao.peng@primarydata.com> <1440577010-122867-2-git-send-email-tao.peng@primarydata.com> <20150826133723.GX10756@twin.jikos.cz> <20150826162154.GD10038@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150826162154.GD10038@birch.djwong.org> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, Aug 26, 2015 at 09:21:54AM -0700, Darrick J. Wong wrote: > On Wed, Aug 26, 2015 at 03:37:23PM +0200, David Sterba wrote: > > On Wed, Aug 26, 2015 at 04:16:42PM +0800, Peng Tao wrote: > > > +struct file_clone_range { > > > + __s64 src_fd; > > > + __u64 src_offset; > > > + __u64 src_length; > > > + __u64 dest_offset; > > > +}; > > > > Might be a good idea to add some spare bytes to the structure. > > But... structure size is encoded in the ioctl definition, so adding bytes > to struct file_clone_range now will change the ioctl number and break > userland. Oh right, I somehow did not left idea of a new ioctl definition while writing it. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Sterba Subject: Re: [PATCH-RFC-RESEND 1/9] vfs: pull btrfs clone API to vfs layer Date: Wed, 26 Aug 2015 18:36:33 +0200 Message-ID: <20150826163633.GC10756@suse.cz> References: <1440577010-122867-1-git-send-email-tao.peng@primarydata.com> <1440577010-122867-2-git-send-email-tao.peng@primarydata.com> <20150826133723.GX10756@twin.jikos.cz> <20150826162154.GD10038@birch.djwong.org> Reply-To: dsterba-AlSwsSmVLrQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Peng Tao , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Trond Myklebust , Anna Schumaker , Christoph Hellwig , Zach Brown , Darren Hart , bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org, Jeff Layton , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Darrick J. Wong" Return-path: Content-Disposition: inline In-Reply-To: <20150826162154.GD10038-PTl6brltDGh4DFYR7WNSRA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Aug 26, 2015 at 09:21:54AM -0700, Darrick J. Wong wrote: > On Wed, Aug 26, 2015 at 03:37:23PM +0200, David Sterba wrote: > > On Wed, Aug 26, 2015 at 04:16:42PM +0800, Peng Tao wrote: > > > +struct file_clone_range { > > > + __s64 src_fd; > > > + __u64 src_offset; > > > + __u64 src_length; > > > + __u64 dest_offset; > > > +}; > > > > Might be a good idea to add some spare bytes to the structure. > > But... structure size is encoded in the ioctl definition, so adding bytes > to struct file_clone_range now will change the ioctl number and break > userland. Oh right, I somehow did not left idea of a new ioctl definition while writing it. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html