From: Stephen Hemminger <stephen@networkplumber.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones
Date: Wed, 26 Aug 2015 17:08:02 -0700 [thread overview]
Message-ID: <20150826170802.27eff88c@urahara> (raw)
In-Reply-To: <1440628887-3504-5-git-send-email-xiyou.wangcong@gmail.com>
On Wed, 26 Aug 2015 15:41:26 -0700
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> Currently there is no check for if a qdisc is appropriate
> to be used as the default qdisc. This causes we get no
> error even we set the default qdisc to an inappropriate one
> but an error will be shown up later. This is not good.
>
> Also, for qdisc's like HTB, kernel will just crash when
> we use it as default qdisc, because some data structures are
> not even initialized yet before checking opt == NULL, the cleanup
> doing ->reset() or ->destroy() on them will just crash.
Why not fix the buggy one's instead?
next prev parent reply other threads:[~2015-08-27 0:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 22:41 [Patch net-next 0/5] net_sched: introduce static flags for qdisc's Cong Wang
2015-08-26 22:41 ` [Patch net-next 1/5] net_sched: move some qdisc flag into qdisc ops Cong Wang
2015-08-26 22:41 ` [Patch net-next 2/5] net_sched: move TCQ_F_MQROOT " Cong Wang
2015-08-26 22:41 ` [Patch net-next 3/5] net_sched: use a flag to indicate fifo qdiscs instead of the name Cong Wang
2015-08-26 22:41 ` [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones Cong Wang
2015-08-27 0:08 ` Stephen Hemminger [this message]
2015-08-27 0:14 ` Cong Wang
2015-08-27 22:30 ` David Miller
2015-08-27 22:39 ` Cong Wang
2015-08-27 22:42 ` David Miller
2015-08-27 22:47 ` Cong Wang
2015-08-27 23:18 ` David Miller
2015-08-28 1:49 ` Cong Wang
2015-08-28 4:23 ` David Miller
2015-08-28 12:26 ` Jamal Hadi Salim
2015-08-28 21:39 ` Cong Wang
2015-08-28 23:20 ` David Miller
2015-08-30 19:07 ` Jamal Hadi Salim
2015-09-02 6:05 ` Cong Wang
2015-09-02 6:19 ` David Miller
2015-09-02 6:26 ` Cong Wang
2015-08-26 22:41 ` [Patch net-next 5/5] net_sched: move ingress flag into qdisc ops Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826170802.27eff88c@urahara \
--to=stephen@networkplumber.org \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.