From: Stephen Boyd <sboyd@codeaurora.org>
To: Govindraj Raja <Govindraj.Raja@imgtec.com>
Cc: linux-mips@linux-mips.org, linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Zdenko Pulitika <zdenko.pulitika@imgtec.com>,
Kevin Cernekee <cernekee@chromium.org>,
Ralf Baechle <ralf@linux-mips.org>,
Andrew Bresticker <abrestic@chromium.org>,
James Hartley <James.Hartley@imgtec.com>,
Damien Horsley <Damien.Horsley@imgtec.com>,
James Hogan <James.Hogan@imgtec.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v6 3/4] clk: pistachio: Fix PLL rate calculation in integer mode
Date: Wed, 26 Aug 2015 11:36:38 -0700 [thread overview]
Message-ID: <20150826183638.GQ19120@codeaurora.org> (raw)
In-Reply-To: <1440605500-13274-4-git-send-email-Govindraj.Raja@imgtec.com>
On 08/26, Govindraj Raja wrote:
> From: Zdenko Pulitika <zdenko.pulitika@imgtec.com>
>
> .recalc_rate callback for the fractional PLL doesn't take operating
> mode into account when calculating PLL rate. This results in
> the incorrect PLL rates when PLL is operating in integer mode.
>
> Operating mode of fractional PLL is based on the value of the
> fractional divider. Currently it assumes that the PLL will always
> be configured in fractional mode which may not be
> the case. This may result in the wrong output frequency.
>
> Also vco was calculated based on the current operating mode which
> makes no sense because .set_rate is setting operating mode. Instead,
> vco should be calculated using PLL settings that are about to be set.
>
> Fixes: 43049b0c83f17("CLK: Pistachio: Add PLL driver")
> Cc: <stable@vger.kernel.org> # 4.1
> Reviewed-by: Andrew Bresticker <abrestic@chromium.org>
> Signed-off-by: Zdenko Pulitika <zdenko.pulitika@imgtec.com>
> Signed-off-by: Govindraj Raja <govindraj.raja@imgtec.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-08-26 18:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 16:11 [PATCH v6 0/4] clk: pistachio: Fixes for pll calculations Govindraj Raja
2015-08-26 16:11 ` Govindraj Raja
2015-08-26 16:11 ` [PATCH v6 1/4] clk: pistachio: Fix 32bit integer overflows Govindraj Raja
2015-08-26 16:11 ` Govindraj Raja
2015-08-26 18:36 ` Stephen Boyd
2015-08-26 16:11 ` [PATCH v6 2/4] clk: pistachio: Fix override of clk-pll settings from boot loader Govindraj Raja
2015-08-26 16:11 ` Govindraj Raja
2015-08-26 18:36 ` Stephen Boyd
2015-08-26 16:11 ` [PATCH v6 3/4] clk: pistachio: Fix PLL rate calculation in integer mode Govindraj Raja
2015-08-26 16:11 ` Govindraj Raja
2015-08-26 18:36 ` Stephen Boyd [this message]
2015-08-26 16:11 ` [PATCH v6 4/4] clk: pistachio: correct critical clock list Govindraj Raja
2015-08-26 16:11 ` Govindraj Raja
2015-08-26 18:36 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826183638.GQ19120@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Damien.Horsley@imgtec.com \
--cc=Govindraj.Raja@imgtec.com \
--cc=James.Hartley@imgtec.com \
--cc=James.Hogan@imgtec.com \
--cc=abrestic@chromium.org \
--cc=cernekee@chromium.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-clk@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mturquette@baylibre.com \
--cc=ralf@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stable@vger.kernel.org \
--cc=zdenko.pulitika@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.