From: Mike Frysinger <vapier@gentoo.org>
To: Kees Cook <keescook@chromium.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 2/2] libmount: handle arbitrary line length for mounts
Date: Wed, 26 Aug 2015 18:38:23 -0400 [thread overview]
Message-ID: <20150826223823.GH3116@vapier> (raw)
In-Reply-To: <20150826220230.GA8599@www.outflux.net>
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
On 26 Aug 2015 15:02, Kees Cook wrote:
> + * Read a line with fgets. If it doesn't fit in the existing buffer,
> + * allocate more heap memory for storage until it does fit.
why not just use getline then ?
> + if (fgets (current, remaining, f) == NULL) {
style omits space before the (. comes up a few times in this patch.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-26 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 22:02 [PATCH 2/2] libmount: handle arbitrary line length for mounts Kees Cook
2015-08-26 22:38 ` Mike Frysinger [this message]
2015-08-26 22:44 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826223823.GH3116@vapier \
--to=vapier@gentoo.org \
--cc=keescook@chromium.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.