From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [RFC 2/3] firmware_class: split out transaction helpers Date: Thu, 27 Aug 2015 15:47:27 +0100 Message-ID: <20150827144727.GB3596@codeblueprint.co.uk> References: <1430348859.2189.37.camel@HansenPartnership.com> <1430349052.2189.41.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1430349052.2189.41.camel@HansenPartnership.com> Sender: linux-kernel-owner@vger.kernel.org To: James Bottomley Cc: linux-efi@vger.kernel.org, "Kweh, Hock Leong" , LKML , Andy Lutomirski , Greg Kroah-Hartman , Peter Jones List-Id: linux-efi@vger.kernel.org On Wed, 29 Apr, at 04:10:52PM, James Bottomley wrote: > From: James Bottomley > > The firmware class contains code to manage an arbitrary sized buffer for > discrete read and write operations. We need precisely this ability to update > firmware capsule files (and likely for other transactions as well), so split > out the capability into a library helper > > Signed-off-by: James Bottomley > --- > drivers/base/firmware_class.c | 117 ++++--------------------------- > include/linux/transaction_helper.h | 26 +++++++ > lib/Makefile | 2 +- > lib/transaction_helper.c | 137 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 179 insertions(+), 103 deletions(-) > create mode 100644 include/linux/transaction_helper.h > create mode 100644 lib/transaction_helper.c (Sorry, I'm coming to this incredibly late) This patch is pretty neat and I wish something like this had existed when I originally wrote the EFI capsule patches. James, do you have any plans to resubmit this as a non-RFC? If not, do you mind if I pick this up and rebase my capsule patches ontop of it? -- Matt Fleming, Intel Open Source Technology Center