From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 4/8] tmem: Remove xc_tmem_control mystical arg3 Date: Thu, 27 Aug 2015 14:38:57 -0400 Message-ID: <20150827183856.GE5982@konrad-lan.dumpdata.com> References: <1440673323-6648-1-git-send-email-konrad.wilk@oracle.com> <1440673323-6648-5-git-send-email-konrad.wilk@oracle.com> <55DF083D.3060905@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZV24n-00035q-40 for xen-devel@lists.xenproject.org; Thu, 27 Aug 2015 18:39:05 +0000 Content-Disposition: inline In-Reply-To: <55DF083D.3060905@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Thu, Aug 27, 2015 at 01:53:17PM +0100, Andrew Cooper wrote: > On 27/08/15 12:01, Konrad Rzeszutek Wilk wrote: > > It mentions it but it is never used. The hypercall interface > > knows nothing of this sort of thing either. Lets just remove it. > > > > Signed-off-by: Konrad Rzeszutek Wilk > > It would be nice if you could take the opportunity of changing every > caller to fix the style issues in affected code. There are a huge > number of missing spaces in the parameter lists of calls to > xc_tmem_control() I was soo tempted to do it - but I've been hammered in the rule of 'one logical change per patch' so abstained from mission creep. Do not fear - I will send out another patch that will fix this up :-) > > ~Andrew