From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZV2ZV-0008Pg-U2 for qemu-devel@nongnu.org; Thu, 27 Aug 2015 15:10:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZV2ZQ-0005sw-Qr for qemu-devel@nongnu.org; Thu, 27 Aug 2015 15:10:49 -0400 Received: from e17.ny.us.ibm.com ([129.33.205.207]:40830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZV2ZQ-0005ss-DK for qemu-devel@nongnu.org; Thu, 27 Aug 2015 15:10:44 -0400 Received: from /spool/local by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Aug 2015 15:10:43 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id A348E38C8062 for ; Thu, 27 Aug 2015 15:10:42 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7RJAgPg61407272 for ; Thu, 27 Aug 2015 19:10:42 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7RJAfE2023072 for ; Thu, 27 Aug 2015 15:10:42 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: References: <1440627694-25096-1-git-send-email-mdroth@linux.vnet.ibm.com> <1440627694-25096-3-git-send-email-mdroth@linux.vnet.ibm.com> <20150827134202.25622.79364@loki> Message-ID: <20150827191034.24880.69605@loki> Date: Thu, 27 Aug 2015 14:10:34 -0500 Subject: Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Cc: Paolo Bonzini , yhindin@redhat.com, Leonid Bloch , QEMU Quoting Marc-Andr=C3=A9 Lureau (2015-08-27 09:05:40) > Hi > = > On Thu, Aug 27, 2015 at 3:42 PM, Michael Roth = wrote: > > If we keep the $enabled !=3D "no" logic all the way through, $enabled, > > unless explicitly turned off or missing dependencies, will be > > undefined when the configure options are summarized via: > > > > configure: qemu-ga: report MSI install support in summary > > > > requiring the user to infer whether we'll default to "yes" or "no". > > The current logic in fact defaults to "yes" in function, so with this > > patch we're simply setting that flag early on so we can report "yes" > > rather than undefined. > = > Where is it reported? I don't see that in the configure summary, did > you add it in another patch? Yes, recently patch, only applied to qga-dev currently: https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg03170.html > = > = > -- = > Marc-Andr=C3=A9 Lureau >=20