All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: legacy mode
Date: Thu, 27 Aug 2015 15:45:00 -0500	[thread overview]
Message-ID: <20150827204500.GA4447@mail.hallyn.com> (raw)
In-Reply-To: <20150827202722.GH26785-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>

On Thu, Aug 27, 2015 at 04:27:22PM -0400, Tejun Heo wrote:
> Hello,
> 
> On Thu, Aug 27, 2015 at 03:21:37PM -0500, Serge E. Hallyn wrote:
> > The problem this would solve is running older userspace (i.e. libvirt in
> > a container running an older distro) on a newer kernel which has unified
> > hierarchy mounted.
> 
> But the leaf restriction isn't the only change.  The interface files

That was an example.  It would also have to automatically enable
controllers in child cgroups, and I'm not sure what to do about
the tasks file.

> are different too and for some controllers the basic operation model
> is different, so I don't see how just adding .leaf would do much good.

Yeah and some of these may be a problem, but the problems I outlined
above are the ones which are *really* breaking old userspace.

Keeping in mind what I've seen most people use for containers, what I've
seen in the Documentation/cgroups/unified.txt file shouldn't be too terrible.
My last test was on 3.19.0-18-generic and I assume it gets worse, and
we'll need to proxy attempts at memory limit setting, for instance.

> If the legacy userspace doesn't do any resource control, the leaf rule
> restriction doesn't apply anyway, so nothing to worry about.

My main use case is nested lxc, presumably with systemd inside some of
the nested containers, so this would definately be an issue.

-serge

  parent reply	other threads:[~2015-08-27 20:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 20:21 legacy mode Serge E. Hallyn
     [not found] ` <20150827202137.GA4221-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2015-08-27 20:27   ` Tejun Heo
     [not found]     ` <20150827202722.GH26785-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-08-27 20:45       ` Serge E. Hallyn [this message]
     [not found]         ` <20150827204500.GA4447-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2015-08-27 20:48           ` Tejun Heo
     [not found]             ` <20150827204825.GI26785-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-08-27 21:23               ` Serge E. Hallyn
2015-08-31 22:36               ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150827204500.GA4447@mail.hallyn.com \
    --to=serge-a9i7lubdfnhqt0dzr+alfa@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.