From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZV6ur-00052Z-CL for qemu-devel@nongnu.org; Thu, 27 Aug 2015 19:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZV6uo-0006QR-5D for qemu-devel@nongnu.org; Thu, 27 Aug 2015 19:49:09 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:37246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZV6un-0006Q3-Un for qemu-devel@nongnu.org; Thu, 27 Aug 2015 19:49:06 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Aug 2015 17:49:05 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id A64301FF0045 for ; Thu, 27 Aug 2015 17:40:10 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7RNm14u42467564 for ; Thu, 27 Aug 2015 16:48:01 -0700 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7RNn1r4007967 for ; Thu, 27 Aug 2015 17:49:01 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1440632099-5169-1-git-send-email-marcandre.lureau@redhat.com> References: <1440632099-5169-1-git-send-email-marcandre.lureau@redhat.com> Message-ID: <20150827234704.24880.20175@loki> Date: Thu, 27 Aug 2015 18:47:04 -0500 Subject: Re: [Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: den@openvz.org Quoting marcandre.lureau@redhat.com (2015-08-26 18:34:46) > From: Marc-Andr=C3=A9 Lureau > = > Hi, > = > The following patches for the qemu agent add support for an optionnal > configuration file, and a man page. > = > v3->v4: > - some spelling fixes > - add a patch to allocate in split_list() > - add more details in "copy argument strings" patch > - add some g_free() in config_parse() > - add an assert() after g_key_file_new() Thanks, applied to qga tree with fix-ups noted in 11+12: https://github.com/mdroth/qemu/commits/qga > v2->v3: > - fix compilation in intermediate patch > - remove some extra space in intermediate patch > - add some missing Reviewed-by tags > v1->v2: > - spelling fixes > - change device_path to channel_path > - moving config to GAConfig struct > - do check_is_frozen() during main > - use g_key_file_to_data() for the dump > = > This is related to this RFE: > https://bugzilla.redhat.com/show_bug.cgi?id=3D1101556 > = > Marc-Andr=C3=A9 Lureau (13): > qga: misc spelling > qga: use exit() when parsing options > qga: move string split in separate function > qga: make split_list() return allocated strings > qga: rename 'path' to 'channel_path' > qga: copy argument strings > qga: move option parsing to separate function > qga: fill default options in main() > qga: move agent run in a separate function > qga: free a bit more > qga: add an optional qemu-ga.conf system configuration > qga: add --dump-conf option > qga: start a man page > = > Makefile | 14 +- > qemu-doc.texi | 6 + > qemu-ga.texi | 136 +++++++++++++++ > qga/commands-posix.c | 6 +- > qga/commands-win32.c | 4 +- > qga/main.c | 468 ++++++++++++++++++++++++++++++++++++---------= ------ > qga/qapi-schema.json | 2 +- > 7 files changed, 490 insertions(+), 146 deletions(-) > create mode 100644 qemu-ga.texi > = > -- = > 2.4.3 >=20