From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230])
 by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux))
 id 1ZV7Pr-0002Zz-4v
 for linux-mtd@lists.infradead.org; Fri, 28 Aug 2015 00:21:12 +0000
Received: by pabzx8 with SMTP id zx8so42161997pab.1
 for <linux-mtd@lists.infradead.org>; Thu, 27 Aug 2015 17:20:50 -0700 (PDT)
Date: Thu, 27 Aug 2015 17:20:48 -0700
From: Brian Norris <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org, David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [PATCH mtd-utils] autogenerated dependency files are not being
 utilized properly
Message-ID: <20150828002048.GZ81844@google.com>
References: <1440715702-66843-1-git-send-email-computersforpeace@gmail.com>
 <20150827235613.GE29734@vapier>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150827235613.GE29734@vapier>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Thu, Aug 27, 2015 at 07:56:13PM -0400, Mike Frysinger wrote:
> On 27 Aug 2015 15:48, Brian Norris wrote:
> > -	$(Q)$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $< -g -Wp,-MD,$(BUILDDIR)/.$(<F).dep
> > +	$(Q)$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $< -g -MD -MF $(BUILDDIR)/.$(<F).dep
> 
> fwiw, this has been here since the beginning.

Yeah, at first I thought it was added in your build system refactoring a
few years back, but then I traced it back to the beginning of time^Wgit
history. Anyway, I figured you'd have insight.

> dropping the -Wp makes
> sense to me.  independently, i think it should use -MMD, but others might
> prefer the -MD behavior.

-MMD makes sense to me too, but yes it is independent. I can send
another patch.

> Acked-by: Mike Frysinger <vapier@gentoo.org>

Thanks for the review!

Brian