From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH v7 10/44] [media] media: rename the function that create pad links Date: Fri, 28 Aug 2015 10:08:02 -0300 Message-ID: <20150828100802.6e626e4c@recife.lan> References: <55DCBA2D.9090901@osg.samsung.com> <20150826115403.7a794597@recife.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150826115403.7a794597@recife.lan> Sender: linux-sh-owner@vger.kernel.org To: Shuah Khan Cc: Linux Media Mailing List , Jonathan Corbet , Kyungmin Park , Andrzej Hajda , Sakari Ailus , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , Laurent Pinchart , Hyun Kwon , Michal Simek , =?UTF-8?B?U8O2cmVu?= Brinkmann , Greg Kroah-Hartman , Hans Verkuil , Rafael =?UTF-8?B?TG91cmVuw6dv?= de Lima Chehab , Matthias Schwarzott , Antti Palosaari , Olli Salonen , Tommi Rantala , Haneen Mohammed , Boris List-Id: linux-samsung-soc@vger.kernel.org Em Wed, 26 Aug 2015 11:54:03 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 25 Aug 2015 12:55:41 -0600 > Shuah Khan escreveu: > > > On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: > > > Now that a link can be either between two different graph > > > objects, we'll need to add more functions to create links. > > > > Is this an incomplete sentence. Should it read: "either between > > two different graph objects or two pads" ? > > That would be redundant, as pad is a graph object ;) Renamed the patch description to: With the new API, a link can be either between two PADs or between an interface and an entity. So, we need to use a better name for the function that create links between two pads. So, rename the such function to media_create_pad_link(). No functional changes. This patch was created via this shell script: for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil Regards, Mauro > > > > > > So, rename the existing one that create links only between > > > two pads as media_create_pad_link(). > > > > > > > > No functional changes. > > > > > > This patch was created via this shell script: > > > for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done > > > > > > > Didn't want to experiment with Coccinelle?? :) > > I use Coccinelle, but only when I need more complex changes, as > Coccinelle may mangle with comments. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > Acked-by: Hans Verkuil > > > Signed-off-by: Mauro Carvalho Chehab > > > > > > > Changes look good to me. After fixing the commit log: > > > > Acked-by: Shuah Khan > > > > thanks, > > -- Shuah > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Date: Fri, 28 Aug 2015 13:08:02 +0000 Subject: Re: [PATCH v7 10/44] [media] media: rename the function that create pad links Message-Id: <20150828100802.6e626e4c@recife.lan> List-Id: References: <55DCBA2D.9090901@osg.samsung.com> <20150826115403.7a794597@recife.lan> In-Reply-To: <20150826115403.7a794597@recife.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Em Wed, 26 Aug 2015 11:54:03 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 25 Aug 2015 12:55:41 -0600 > Shuah Khan escreveu: > > > On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: > > > Now that a link can be either between two different graph > > > objects, we'll need to add more functions to create links. > > > > Is this an incomplete sentence. Should it read: "either between > > two different graph objects or two pads" ? > > That would be redundant, as pad is a graph object ;) Renamed the patch description to: With the new API, a link can be either between two PADs or between an interface and an entity. So, we need to use a better name for the function that create links between two pads. So, rename the such function to media_create_pad_link(). No functional changes. This patch was created via this shell script: for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil Regards, Mauro > > > > > > So, rename the existing one that create links only between > > > two pads as media_create_pad_link(). > > > > > > > > No functional changes. > > > > > > This patch was created via this shell script: > > > for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done > > > > > > > Didn't want to experiment with Coccinelle?? :) > > I use Coccinelle, but only when I need more complex changes, as > Coccinelle may mangle with comments. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > Acked-by: Hans Verkuil > > > Signed-off-by: Mauro Carvalho Chehab > > > > > > > Changes look good to me. After fixing the commit log: > > > > Acked-by: Shuah Khan > > > > thanks, > > -- Shuah > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: mchehab@infradead.org (Mauro Carvalho Chehab) Date: Fri, 28 Aug 2015 10:08:02 -0300 Subject: [PATCH v7 10/44] [media] media: rename the function that create pad links In-Reply-To: <20150826115403.7a794597@recife.lan> References: <55DCBA2D.9090901@osg.samsung.com> <20150826115403.7a794597@recife.lan> Message-ID: <20150828100802.6e626e4c@recife.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Em Wed, 26 Aug 2015 11:54:03 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 25 Aug 2015 12:55:41 -0600 > Shuah Khan escreveu: > > > On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: > > > Now that a link can be either between two different graph > > > objects, we'll need to add more functions to create links. > > > > Is this an incomplete sentence. Should it read: "either between > > two different graph objects or two pads" ? > > That would be redundant, as pad is a graph object ;) Renamed the patch description to: With the new API, a link can be either between two PADs or between an interface and an entity. So, we need to use a better name for the function that create links between two pads. So, rename the such function to media_create_pad_link(). No functional changes. This patch was created via this shell script: for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil Regards, Mauro > > > > > > So, rename the existing one that create links only between > > > two pads as media_create_pad_link(). > > > > > > > > No functional changes. > > > > > > This patch was created via this shell script: > > > for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done > > > > > > > Didn't want to experiment with Coccinelle?? :) > > I use Coccinelle, but only when I need more complex changes, as > Coccinelle may mangle with comments. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > Acked-by: Hans Verkuil > > > Signed-off-by: Mauro Carvalho Chehab > > > > > > > Changes look good to me. After fixing the commit log: > > > > Acked-by: Shuah Khan > > > > thanks, > > -- Shuah > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:56015 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbbH1NIQ (ORCPT ); Fri, 28 Aug 2015 09:08:16 -0400 Date: Fri, 28 Aug 2015 10:08:02 -0300 From: Mauro Carvalho Chehab To: Shuah Khan Cc: Linux Media Mailing List , Jonathan Corbet , Kyungmin Park , Andrzej Hajda , Sakari Ailus , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , Laurent Pinchart , Hyun Kwon , Michal Simek , =?UTF-8?B?U8O2cmVu?= Brinkmann , Greg Kroah-Hartman , Hans Verkuil , Rafael =?UTF-8?B?TG91cmVuw6dv?= de Lima Chehab , Matthias Schwarzott , Antti Palosaari , Olli Salonen , Tommi Rantala , Haneen Mohammed , Boris BREZILLON , Navya Sri Nizamkari , Tapasweni Pathak , Mahati Chamarthy , anuvazhayil , Prabhakar Lad , Jiayi Ye , Heena Sirwani , Wolfram Sang , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sh@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH v7 10/44] [media] media: rename the function that create pad links Message-ID: <20150828100802.6e626e4c@recife.lan> In-Reply-To: <20150826115403.7a794597@recife.lan> References: <55DCBA2D.9090901@osg.samsung.com> <20150826115403.7a794597@recife.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Wed, 26 Aug 2015 11:54:03 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 25 Aug 2015 12:55:41 -0600 > Shuah Khan escreveu: > > > On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: > > > Now that a link can be either between two different graph > > > objects, we'll need to add more functions to create links. > > > > Is this an incomplete sentence. Should it read: "either between > > two different graph objects or two pads" ? > > That would be redundant, as pad is a graph object ;) Renamed the patch description to: With the new API, a link can be either between two PADs or between an interface and an entity. So, we need to use a better name for the function that create links between two pads. So, rename the such function to media_create_pad_link(). No functional changes. This patch was created via this shell script: for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil Regards, Mauro > > > > > > So, rename the existing one that create links only between > > > two pads as media_create_pad_link(). > > > > > > > > No functional changes. > > > > > > This patch was created via this shell script: > > > for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done > > > > > > > Didn't want to experiment with Coccinelle?? :) > > I use Coccinelle, but only when I need more complex changes, as > Coccinelle may mangle with comments. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > Acked-by: Hans Verkuil > > > Signed-off-by: Mauro Carvalho Chehab > > > > > > > Changes look good to me. After fixing the commit log: > > > > Acked-by: Shuah Khan > > > > thanks, > > -- Shuah > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html