From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] lib: Optionally initialize mmio register access without forcewake
Date: Fri, 28 Aug 2015 18:44:50 +0300 [thread overview]
Message-ID: <20150828154450.GZ5176@intel.com> (raw)
In-Reply-To: <1440773507-21799-2-git-send-email-mika.kuoppala@intel.com>
On Fri, Aug 28, 2015 at 05:51:46PM +0300, Mika Kuoppala wrote:
> Sometimes it is beneficial to debug the forcewake registers
> themselves or registers that don't need or are interfered by
> forcewake. Add parameter to intel_register_access_init()
> to optionally avoid forcewake dance around register access.
>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> debugger/debug_rdata.c | 2 +-
> debugger/eudb.c | 2 +-
> lib/intel_io.h | 2 +-
> lib/intel_mmio.c | 9 +++++++--
> tests/gem_workarounds.c | 2 +-
> tests/pm_lpsp.c | 2 +-
> tools/intel_display_poller.c | 2 +-
> tools/intel_forcewaked.c | 4 ++--
> tools/intel_gpu_top.c | 2 +-
> tools/intel_infoframes.c | 2 +-
> tools/intel_l3_parity.c | 2 +-
> tools/intel_panel_fitter.c | 2 +-
> tools/intel_perf_counters.c | 2 +-
> tools/intel_reg.c | 6 +++---
> tools/intel_watermark.c | 14 +++++++-------
> tools/quick_dump/chipset.i | 4 ++--
> 16 files changed, 32 insertions(+), 27 deletions(-)
>
> diff --git a/debugger/debug_rdata.c b/debugger/debug_rdata.c
> index 61d82d9..2643581 100644
> --- a/debugger/debug_rdata.c
> +++ b/debugger/debug_rdata.c
<snip>
> @@ -187,7 +188,11 @@ intel_register_access_init(struct pci_device *pci_dev, int safe)
> /* Find where the forcewake lock is. Forcewake doesn't exist
> * gen < 6, but the debugfs should do the right things for us.
> */
> - ret = igt_open_forcewake_handle();
> + if (nofw)
> + ret = -1;
> + else
> + ret = igt_open_forcewake_handle();
IGT_NO_FORCEWAKE is handled in igt_open_forcewake_handle(). Maybe pull
it out so that all ways to disable forcewake are handled in the same
place?
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-28 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 14:51 [PATCH 1/3] tools/intel_reg: Use pci device from config on write Mika Kuoppala
2015-08-28 14:51 ` [PATCH 2/3] lib: Optionally initialize mmio register access without forcewake Mika Kuoppala
2015-08-28 15:12 ` Jani Nikula
2015-08-28 15:44 ` Ville Syrjälä [this message]
2015-08-28 14:51 ` [PATCH 3/3] tools/intel_reg: Add option to skip forcewake Mika Kuoppala
2015-08-28 15:16 ` Jani Nikula
2015-08-28 15:16 ` [PATCH 1/3] tools/intel_reg: Use pci device from config on write Jani Nikula
2015-09-09 13:50 ` Thomas Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828154450.GZ5176@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.