From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 06/17] drm/i915: Move {pin, long}_mask initialization to caller from intel_get_hpd_pins() Date: Fri, 28 Aug 2015 21:25:36 +0300 Message-ID: <20150828182536.GI5176@intel.com> References: <1440708972-17112-1-git-send-email-ville.syrjala@linux.intel.com> <1440708972-17112-7-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 649176E2E1 for ; Fri, 28 Aug 2015 11:25:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMjgsIDIwMTUgYXQgMDM6MDE6NTBQTSAtMDMwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IDIwMTUtMDgtMjcgMTc6NTYgR01ULTAzOjAwICA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Ogo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+Cj4gPiBNb3ZlIHRoZSAwIGluaXRpYWxpemF0aW9uIG9mIHBpbl9tYXNr IGFuZCBsb25nX21hc2sgZnJvbQo+ID4gaW50ZWxfZ2V0X2hwZF9waW5zKCkgaW50byBlYWNoIGNh bGxlci4gVGhpcyB3ZSB3ZSBjYW4gY2FsbAo+ID4gaW50ZWxfZ2V0X2hwZF9waW5zKCkgbXVsdGlw bGUgdGltZXMgdG8gYWNjdW11bGF0ZSBtb3JlIHBpbnMgZnJvbSBzZXZlcmFsCj4gPiBzb3VyY2Vz Lgo+IAo+IEhtbS4uLiBJJ20gbm90IGEgYmlnIGZhbiBvZiB0aGlzIGFwcHJvYWNoIHNpbmNlIGl0 IG1ha2VzIHRoZSBjb2RlIG1vcmUKPiBkYW5nZXJvdXMuIEkgd291bGRuJ3QgYmUgc3VycHJpc2Vk IGlmIG5leHQgeWVhciB3ZSBkaXNjb3ZlciB0aGF0IHRoZQo+IGNvZGUgZm9yIHRoZSBuZXh0IGhh cmR3YXJlIGdlbmVyYXRpb24gZm9yZ290IHRvIHplcm8taW5pdGlhbGl6ZSB0aGUKPiB2YXJpYWJs ZXMuIFlvdSBrbm93LCBwcm9ncmFtbWVycyBmcm9tIHRoZSBmdXR1cmUgYXJlIGFsd2F5cyByZWFs bHkKPiBiYWQuCgpZZWFoIHRoZXJlJ3MgYSBzbGlnaHQgZGFuZ2VyLiBCdXQgYWZ0ZXIgdGhlIHNl cmllcyBhbGwgdGhlIGhwZCBoYW5kbGluZwppcyByYXRoZXIgdW5pZm9ybSBsb29raW5nLCBzbyBo b3BlZnVsbHkgdGhlIGZ1dHVyZSBwcm9ncmFtbWVycyB3aWxsIGp1c3QKcmVzb3J0IHRvIGNvcHkt cGFzdGUgYW5kIGdldCBpdCByaWdodCA7KQoKPiAKPiBZb3UgY291bGQgYXQgbGVhc3Qgd3JpdGUg YSBzbWFsbCBjb21tZW50IGF0IHRoZSB0b3Agb2YKPiBpbnRlbF9nZXRfaHBkX3BpbnMoKSB0ZWxs aW5nIHRoZSBjYWxsZXJzIHRvIGNsZWFyIHRoZWlyIG1hc2tzIGZpcnN0LgoKRG9uZS4KCj4gCj4g SSB3b3VsZCBzdGlsbCBwcmVmZXIgbXkgb3JpZ2luYWwgc3VnZ2VzdGlvbiBvZiBoYXZpbmcgMiB2 YXJpYWJsZXMgZm9yCj4gcGVvcGxlIHdobyBjYWxsIHRoaXMgdHdpY2UsIGJ1dCB0aGlzIG9uZSBp cyBjb3JyZWN0LCBzbzoKPiBSZXZpZXdlZC1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9u aUBpbnRlbC5jb20+Cj4gCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfaXJxLmMgfCAxMSArKysrLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0 IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2ly cS5jCj4gPiBpbmRleCAzMzg4YjY0Li5kYjI3OTQ1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9pcnEuYwo+ID4gQEAgLTEzMDEsOSArMTMwMSw2IEBAIHN0YXRpYyB2b2lkIGludGVsX2dldF9o cGRfcGlucyh1MzIgKnBpbl9tYXNrLCB1MzIgKmxvbmdfbWFzaywKPiA+ICAgICAgICAgZW51bSBw b3J0IHBvcnQ7Cj4gPiAgICAgICAgIGludCBpOwo+ID4KPiA+IC0gICAgICAgKnBpbl9tYXNrID0g MDsKPiA+IC0gICAgICAgKmxvbmdfbWFzayA9IDA7Cj4gPiAtCj4gPiAgICAgICAgIGZvcl9lYWNo X2hwZF9waW4oaSkgewo+ID4gICAgICAgICAgICAgICAgIGlmICgoaHBkW2ldICYgaG90cGx1Z190 cmlnZ2VyKSA9PSAwKQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cj4gPiBA QCAtMTU0NCw3ICsxNTQxLDcgQEAgc3RhdGljIHZvaWQgaTl4eF9ocGRfaXJxX2hhbmRsZXIoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICB7Cj4gPiAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiAgICAgICAgIHUzMiBob3Rw bHVnX3N0YXR1cyA9IEk5MTVfUkVBRChQT1JUX0hPVFBMVUdfU1RBVCk7Cj4gPiAtICAgICAgIHUz MiBwaW5fbWFzaywgbG9uZ19tYXNrOwo+ID4gKyAgICAgICB1MzIgcGluX21hc2sgPSAwLCBsb25n X21hc2sgPSAwOwo+ID4KPiA+ICAgICAgICAgaWYgKCFob3RwbHVnX3N0YXR1cykKPiA+ICAgICAg ICAgICAgICAgICByZXR1cm47Cj4gPiBAQCAtMTY3Myw3ICsxNjcwLDcgQEAgc3RhdGljIHZvaWQg aWJ4X2lycV9oYW5kbGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiBwY2hfaWlyKQo+ID4g ICAgICAgICB1MzIgaG90cGx1Z190cmlnZ2VyID0gcGNoX2lpciAmIFNERV9IT1RQTFVHX01BU0s7 Cj4gPgo+ID4gICAgICAgICBpZiAoaG90cGx1Z190cmlnZ2VyKSB7Cj4gPiAtICAgICAgICAgICAg ICAgdTMyIGRpZ19ob3RwbHVnX3JlZywgcGluX21hc2ssIGxvbmdfbWFzazsKPiA+ICsgICAgICAg ICAgICAgICB1MzIgZGlnX2hvdHBsdWdfcmVnLCBwaW5fbWFzayA9IDAsIGxvbmdfbWFzayA9IDA7 Cj4gPgo+ID4gICAgICAgICAgICAgICAgIGRpZ19ob3RwbHVnX3JlZyA9IEk5MTVfUkVBRChQQ0hf UE9SVF9IT1RQTFVHKTsKPiA+ICAgICAgICAgICAgICAgICBJOTE1X1dSSVRFKFBDSF9QT1JUX0hP VFBMVUcsIGRpZ19ob3RwbHVnX3JlZyk7Cj4gPiBAQCAtMTc4MSw3ICsxNzc4LDcgQEAgc3RhdGlj IHZvaWQgY3B0X2lycV9oYW5kbGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHUzMiBwY2hfaWly KQo+ID4gICAgICAgICAgICAgICAgIGhvdHBsdWdfdHJpZ2dlciA9IHBjaF9paXIgJiBTREVfSE9U UExVR19NQVNLX0NQVDsKPiA+Cj4gPiAgICAgICAgIGlmIChob3RwbHVnX3RyaWdnZXIpIHsKPiA+ IC0gICAgICAgICAgICAgICB1MzIgZGlnX2hvdHBsdWdfcmVnLCBwaW5fbWFzaywgbG9uZ19tYXNr Owo+ID4gKyAgICAgICAgICAgICAgIHUzMiBkaWdfaG90cGx1Z19yZWcsIHBpbl9tYXNrID0gMCwg bG9uZ19tYXNrID0gMDsKPiA+Cj4gPiAgICAgICAgICAgICAgICAgZGlnX2hvdHBsdWdfcmVnID0g STkxNV9SRUFEKFBDSF9QT1JUX0hPVFBMVUcpOwo+ID4gICAgICAgICAgICAgICAgIEk5MTVfV1JJ VEUoUENIX1BPUlRfSE9UUExVRywgZGlnX2hvdHBsdWdfcmVnKTsKPiA+IEBAIC0yMDA0LDcgKzIw MDEsNyBAQCBzdGF0aWMgdm9pZCBieHRfaHBkX2hhbmRsZXIoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgdWludDMyX3QgaWlyX3N0YXR1cykKPiA+ICB7Cj4gPiAgICAgICAgIHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiAgICAgICAgIHUzMiBo cF9jb250cm9sLCBocF90cmlnZ2VyOwo+ID4gLSAgICAgICB1MzIgcGluX21hc2ssIGxvbmdfbWFz azsKPiA+ICsgICAgICAgdTMyIHBpbl9tYXNrID0gMCwgbG9uZ19tYXNrID0gMDsKPiA+Cj4gPiAg ICAgICAgIC8qIEdldCB0aGUgc3RhdHVzICovCj4gPiAgICAgICAgIGhwX3RyaWdnZXIgPSBpaXJf c3RhdHVzICYgQlhUX0RFX1BPUlRfSE9UUExVR19NQVNLOwo+ID4gLS0KPiA+IDIuNC42Cj4gPgo+ ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKPiAKPiAKPiAKPiAtLSAKPiBQYXVsbyBaYW5vbmkKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50 ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==