From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Peter Mamonov <pmamonov@gmail.com>
Subject: Re: [RFC 7/9] usb: ehci: add big-endian registers support
Date: Fri, 28 Aug 2015 18:49:39 +0300 [thread overview]
Message-ID: <20150828184939.b90155d77eaa3333c44899be@gmail.com> (raw)
In-Reply-To: <20150828061900.GZ18700@pengutronix.de>
On Fri, 28 Aug 2015 08:19:00 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Fri, Aug 28, 2015 at 01:24:08AM +0300, Antony Pavlov wrote:
> > +
> > +#ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
> > +#define ehci_big_endian_mmio(e) ((e)->big_endian_mmio)
> > +#else
> > +#define ehci_big_endian_mmio(e) 0
> > +#endif
> > +
> > +static inline void ehci_writel(const struct ehci_priv *ehci,
> > + __u32 __iomem *regs, const unsigned int val)
> > {
> > - writel(val, regs);
> > + if (IS_ENABLED(CONFIG_USB_EHCI_BIG_ENDIAN_MMIO)) {
> > + ehci_big_endian_mmio(ehci) ?
> > + iowrite32be(val, regs) :
> > + writel(val, regs);
> > + } else
> > + writel(val, regs);
> > }
>
> if (ehci_big_endian_mmio(ehci))
> iowrite32be(val, regs);
> else
> writel(val, regs);
>
> is enough.
It looks you are right. :)
I have just stealed this code from linux kernel.
I have some suspicions on redundancy of this code but I didn't proposed any good solution.
Thanks!
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-08-28 15:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 22:24 [RFC 0/9] ehci-hcd.c: make it works on big-endian mips (AR9331) Antony Pavlov
2015-08-27 22:24 ` [RFC 1/9] WIP: make ehci-hcd.c happy on big-endian MIPS Antony Pavlov
2015-08-27 22:24 ` [RFC 2/9] WIP: fix drivers/usb/core/usb.c Antony Pavlov
2015-08-28 6:11 ` Sascha Hauer
2015-08-28 15:51 ` Antony Pavlov
2015-08-31 6:45 ` Sascha Hauer
2015-08-27 22:24 ` [RFC 3/9] MIPS: add virt_to_phys() and phys_to_virt() Antony Pavlov
2015-08-28 6:34 ` Sascha Hauer
2015-08-28 15:46 ` Antony Pavlov
2015-09-04 6:20 ` Sascha Hauer
2015-09-04 7:27 ` Antony Pavlov
2015-09-04 8:44 ` Sascha Hauer
2015-12-06 14:50 ` Antony Pavlov
2015-12-07 10:27 ` Sascha Hauer
2015-12-08 9:11 ` Antony Pavlov
2015-12-08 11:46 ` Peter Mamonov
2015-12-09 13:03 ` Sascha Hauer
2015-08-27 22:24 ` [RFC 4/9] MIPS: add trivial dma support Antony Pavlov
2015-08-27 22:24 ` [RFC 5/9] ehci-hcd.c: make it works on mips Antony Pavlov
2015-08-27 22:24 ` [RFC 6/9] usb: ehci: drop unusable CONFIG_EHCI_MMIO_BIG_ENDIAN condition Antony Pavlov
2015-08-27 22:24 ` [RFC 7/9] usb: ehci: add big-endian registers support Antony Pavlov
2015-08-28 6:19 ` Sascha Hauer
2015-08-28 15:49 ` Antony Pavlov [this message]
2015-08-27 22:24 ` [RFC 8/9] MIPS: tplink-mr3020: select big-endian EHCI support Antony Pavlov
2015-08-27 22:24 ` [RFC 9/9] MIPS: tplink-mr3020_defconfig: enable usb stuff Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828184939.b90155d77eaa3333c44899be@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=pmamonov@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.