From: Thomas Graf <tgraf@suug.ch>
To: lkp@lists.01.org
Subject: Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads
Date: Sat, 29 Aug 2015 00:43:03 +0200 [thread overview]
Message-ID: <20150828224303.GD32001@pox.localdomain> (raw)
In-Reply-To: <20150828133437.GM20760@orbit.nwl.cc>
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
On 08/28/15 at 03:34pm, Phil Sutter wrote:
> Quite ugly, IMHO: rhashtable_insert_fast() may return -ENOMEM as
> non-permanent error, if allocation in GFP_ATOMIC failed. In this case,
> allocation in GFP_KERNEL is retried by rht_deferred_worker(). Sadly,
> there is no way to determine if that has already been tried and failed.
>
> The thread test triggers GFP_ATOMIC allocation failure quite easily, so
> I can't really just ignore this issue. :)
Return EBUSY or ENOBUFS in the non-permanent case? It is definitely
helpful if the API allows to differ between permanent and
non-permanent errors.
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Graf <tgraf@suug.ch>
To: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
wfg@linux.intel.com, lkp@01.org
Subject: Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads
Date: Sat, 29 Aug 2015 00:43:03 +0200 [thread overview]
Message-ID: <20150828224303.GD32001@pox.localdomain> (raw)
In-Reply-To: <20150828133437.GM20760@orbit.nwl.cc>
On 08/28/15 at 03:34pm, Phil Sutter wrote:
> Quite ugly, IMHO: rhashtable_insert_fast() may return -ENOMEM as
> non-permanent error, if allocation in GFP_ATOMIC failed. In this case,
> allocation in GFP_KERNEL is retried by rht_deferred_worker(). Sadly,
> there is no way to determine if that has already been tried and failed.
>
> The thread test triggers GFP_ATOMIC allocation failure quite easily, so
> I can't really just ignore this issue. :)
Return EBUSY or ENOBUFS in the non-permanent case? It is definitely
helpful if the API allows to differ between permanent and
non-permanent errors.
next prev parent reply other threads:[~2015-08-28 22:43 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 10:28 [PATCH 1/3] rhashtable-test: add cond_resched() to thread test Phil Sutter
2015-08-28 10:28 ` [PATCH 2/3] rhashtable-test: retry insert operations in threads Phil Sutter
2015-08-28 11:09 ` Thomas Graf
2015-08-28 11:09 ` Thomas Graf
2015-08-28 11:13 ` Phil Sutter
2015-08-28 13:34 ` Phil Sutter
2015-08-28 22:43 ` Thomas Graf [this message]
2015-08-28 22:43 ` Thomas Graf
2015-08-29 9:07 ` Phil Sutter
2015-08-30 7:47 ` Herbert Xu
2015-08-30 7:47 ` Herbert Xu
2015-08-31 11:00 ` Phil Sutter
2015-09-01 11:43 ` Herbert Xu
2015-09-01 11:43 ` Herbert Xu
2015-09-01 12:46 ` Phil Sutter
2015-09-01 13:00 ` Herbert Xu
2015-09-01 13:00 ` Herbert Xu
2015-09-01 13:40 ` Eric Dumazet
2015-09-01 13:40 ` Eric Dumazet
2015-09-01 13:43 ` Phil Sutter
2015-09-01 13:50 ` Herbert Xu
2015-09-01 13:50 ` Herbert Xu
2015-09-01 13:56 ` Phil Sutter
2015-09-01 14:03 ` Herbert Xu
2015-09-01 14:03 ` Herbert Xu
2015-09-01 14:13 ` Thomas Graf
2015-09-01 14:13 ` Thomas Graf
2015-09-01 14:16 ` Herbert Xu
2015-09-01 14:16 ` Herbert Xu
2015-09-01 14:51 ` Thomas Graf
2015-09-01 14:51 ` Thomas Graf
2015-09-02 2:00 ` Herbert Xu
2015-09-02 2:00 ` Herbert Xu
2015-09-02 7:07 ` Thomas Graf
2015-09-02 7:07 ` Thomas Graf
2015-09-10 8:03 ` Herbert Xu
2015-09-10 8:03 ` Herbert Xu
2015-09-10 10:05 ` Phil Sutter
2015-08-28 10:28 ` [PATCH 3/3] rhashtable-test: calculate max_entries value by default Phil Sutter
2015-08-28 11:11 ` Thomas Graf
2015-08-28 11:11 ` Thomas Graf
2015-08-28 11:03 ` [PATCH 1/3] rhashtable-test: add cond_resched() to thread test Thomas Graf
2015-08-28 11:03 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828224303.GD32001@pox.localdomain \
--to=tgraf@suug.ch \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.