From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: max8997_haptic - Fix module alias
Date: Fri, 28 Aug 2015 17:31:06 -0700 [thread overview]
Message-ID: <20150829003106.GC8298@dtor-ws> (raw)
In-Reply-To: <1440548381-4148-1-git-send-email-javier@osg.samsung.com>
On Wed, Aug 26, 2015 at 02:19:41AM +0200, Javier Martinez Canillas wrote:
> The driver is a platform driver and not a I2C driver so its modalias
> should be exported with MODULE_DEVICE_TABLE(platform,...) instead of
> MODULE_DEVICE_TABLE(i2c,...).
>
> Also, remove the unnecessary MODULE_ALIAS("platform:max8997-haptic")
> now that the correct module alias is created.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
>
> ---
>
> drivers/input/misc/max8997_haptic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c
> index d0f687281339..a806ba3818f7 100644
> --- a/drivers/input/misc/max8997_haptic.c
> +++ b/drivers/input/misc/max8997_haptic.c
> @@ -394,7 +394,7 @@ static const struct platform_device_id max8997_haptic_id[] = {
> { "max8997-haptic", 0 },
> { },
> };
> -MODULE_DEVICE_TABLE(i2c, max8997_haptic_id);
> +MODULE_DEVICE_TABLE(platform, max8997_haptic_id);
>
> static struct platform_driver max8997_haptic_driver = {
> .driver = {
> @@ -407,7 +407,6 @@ static struct platform_driver max8997_haptic_driver = {
> };
> module_platform_driver(max8997_haptic_driver);
>
> -MODULE_ALIAS("platform:max8997-haptic");
> MODULE_AUTHOR("Donggeun Kim <dg77.kim@samsung.com>");
> MODULE_DESCRIPTION("max8997_haptic driver");
> MODULE_LICENSE("GPL");
> --
> 2.4.3
>
--
Dmitry
prev parent reply other threads:[~2015-08-29 0:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 0:19 [PATCH] Input: max8997_haptic - Fix module alias Javier Martinez Canillas
2015-08-29 0:31 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150829003106.GC8298@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jg1.han@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.