From: "Frank Ch. Eigler" <fche@redhat.com>
To: rusty@rustcorp.com.au
Cc: linux-kernel@vger.kernel.org
Subject: timing of module MODULE_STATE_COMING notifier
Date: Sun, 30 Aug 2015 20:06:42 -0400 [thread overview]
Message-ID: <20150831000642.GG29756@redhat.com> (raw)
Hi, Rusty -
We just [1] came across your patch [2] from last year (merged into
3.17), wherein the RO/NX mapping settings for module sections were
moved to an earlier point in the module-loading sequence.
That patch also moved the MODULE_STATE_COMING notifier call to
complete_formation(), which is relatively early to its former
do_init_module() call site. It now precedes the parse_args(),
mod_sysfs_setup(), and trace_module_load() steps.
Was the latter part of the change intended & necessary? It is
negatively impacting systemtap, which was relying on
MODULE_STATE_COMING being called from a fairly complete module state -
just before the actual initializer function call.
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=18889
[2] commit 4982223e51e8ea9d09bb33c8323b5ec1877b2b51
Author: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed May 14 10:54:19 2014 +0930
- FChE
next reply other threads:[~2015-08-31 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 0:06 Frank Ch. Eigler [this message]
2015-08-31 1:36 ` timing of module MODULE_STATE_COMING notifier Rusty Russell
2015-08-31 12:53 ` Frank Ch. Eigler
2015-08-31 20:40 ` Frank Ch. Eigler
2015-09-02 6:02 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831000642.GG29756@redhat.com \
--to=fche@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.