From: Stefan Dirsch <sndirsch@suse.de>
To: Thomas Wood <thomas.wood@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] intel-gpu-tools: Fixes-compiler-warnings-about-wrong-function-type
Date: Mon, 31 Aug 2015 12:12:30 +0200 [thread overview]
Message-ID: <20150831101229.GA7702@suse.de> (raw)
In-Reply-To: <CANkqdn0dtif5OWTLLMit3o8LHoMEng4wkSG6u4CHchjHvF1-gQ@mail.gmail.com>
On Wed, Aug 26, 2015 at 11:42:23AM +0100, Thomas Wood wrote:
> On 24 August 2015 at 10:59, Stefan Dirsch <sndirsch@suse.de> wrote:
> > Hi
> >
> > Find a simple buildfix against current intel-gpu-tools git sources attached.
>
> I assume the compiler warning is about uninitialised values and unused
> variables? It looks like the Makefile is not using the debug cflags so
> these warning do not appear by default.
Warnings/error were:
W: intel-gpu-tools uninitialized-variable intel_renderstate_gen9.c:476
E: intel-gpu-tools no-return-in-nonvoid-function intel_renderstate_gen8.c:441
> intel_null_state_gen.c appears to assume the
> gen*_setup_null_render_state functions have return values in the
> extern declarations, so this could do with fixing too.
Indeed your patches fixes these warnings/errors. So no need any longer to
include/review my patch as long as your patch gets integrated. ;-)
Thanks,
Stefan
Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.) SUSE LINUX GmbH
Tel: 0911-740 53 0 Maxfeldstraße 5
FAX: 0911-740 53 479 D-90409 Nürnberg
http://www.suse.de Germany
---------------------------------------------------------------
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---------------------------------------------------------------
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-08-31 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 9:59 [PATCH] intel-gpu-tools: Fixes-compiler-warnings-about-wrong-function-type Stefan Dirsch
2015-08-26 10:42 ` Thomas Wood
2015-08-28 14:11 ` [PATCH i-g-t] tools/null_state_gen: fix various compiler warnings Thomas Wood
2015-08-28 14:38 ` Mika Kuoppala
2015-08-31 10:12 ` Stefan Dirsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831101229.GA7702@suse.de \
--to=sndirsch@suse.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.