From: Brian Norris <computersforpeace@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [RFC / BUG] mtd: provide proper 32/64-bit compat_ioctl() support for BLKPG
Date: Mon, 31 Aug 2015 11:01:42 -0700 [thread overview]
Message-ID: <20150831180142.GB81844@google.com> (raw)
In-Reply-To: <1440814356-52070-1-git-send-email-computersforpeace@gmail.com>
On Fri, Aug 28, 2015 at 07:12:36PM -0700, Brian Norris wrote:
> The same bug applies to block/ioctl.c
Actually I'll correct myself: it looks like block/ already has OK
compat_ioctl support for this. Block devices do a copy to/from user
space to marshal a new struct. Personally, I find my approach a little
clearer.
> But then: which tree should it go in?
I guess since this is only an MTD bug, then it'd be fair to take via
MTD. I'll plan to do that eventually if there are no objections.
> Tested only on MTD, with an ARM32 user space on an ARM64 kernel.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> drivers/mtd/mtdchar.c | 42 +++++++++++++++++++++++++++++++++---------
> include/uapi/linux/blkpg.h | 10 ++++++++++
> 2 files changed, 43 insertions(+), 9 deletions(-)
I also suspect it might make more sense to move the compat definitions
to a new non-UAPI include/linux/blkpg.h. I'll probably put that in v2.
Brian
next prev parent reply other threads:[~2015-08-31 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 2:12 [RFC / BUG] mtd: provide proper 32/64-bit compat_ioctl() support for BLKPG Brian Norris
2015-08-31 18:01 ` Brian Norris [this message]
2015-09-21 20:26 ` [PATCH] " Brian Norris
2015-09-29 20:37 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831180142.GB81844@google.com \
--to=computersforpeace@gmail.com \
--cc=axboe@kernel.dk \
--cc=dwmw2@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.