From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from comal.ext.ti.com ([198.47.26.152]:49806 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbbHaSuN (ORCPT ); Mon, 31 Aug 2015 14:50:13 -0400 Date: Mon, 31 Aug 2015 13:50:10 -0500 From: Felipe Balbi To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= CC: Felipe Balbi , Greg Kroah-Hartman , , Subject: Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs" Message-ID: <20150831185010.GH31101@saruman.tx.rr.com> Reply-To: References: <1441039708-2504-1-git-send-email-ville.syrjala@linux.intel.com> <20150831165413.GF31101@saruman.tx.rr.com> <20150831172510.GC29811@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="D6IIOQQv2Iwyp54J" Content-Disposition: inline In-Reply-To: <20150831172510.GC29811@intel.com> Sender: stable-owner@vger.kernel.org List-ID: --D6IIOQQv2Iwyp54J Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Aug 31, 2015 at 08:25:10PM +0300, Ville Syrj=E4l=E4 wrote: > On Mon, Aug 31, 2015 at 11:54:13AM -0500, Felipe Balbi wrote: > > On Mon, Aug 31, 2015 at 07:48:28PM +0300, ville.syrjala@linux.intel.com= wrote: > > > From: Ville Syrj=E4l=E4 > > >=20 > > > This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. > > >=20 > > > As it breaks g_ether on my Baytrail FFRD8 device. Everything starts o= ut > > > fine, but after a bit of data has been transferred it just stops > > > flowing. > > >=20 > > > Note that I do get a bunch of these "NOHZ: local_softirq_pending 08" > > > when booting the machine, but I'm not really sure if they're related > > > to this problem. > >=20 > > I have a feeling your problem is elsewhere. We *are* completing one TRB > > at a time. By reverting that commit you're just masking the real problem > > and I'd rather get that one fixed. > >=20 > > How do you reproduce your issue ? >=20 > Just boot the system, it gets an IP from dnsmasq on my host, then I ssh > into it and do something to produce a bit of console output, after which > g_ether is dead. Eg. 'dmesg' a few times is enough to kill it. which kernel version ? Running as USB2 or USB3 ? Have you tried linux-next ? I just did 1000 dmesg iterations over ssh with g_ether and saw no issues. Can you enable dwc3 tracepoints and try again ? (use some very large trace buffer, something around 2 or 4 MiB should be enough). cheers --=20 balbi --D6IIOQQv2Iwyp54J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV5KHiAAoJEIaOsuA1yqREz4UP/Ahl9SjKrhOFwsX/jluJA9lI T1k+rNmMjrfrne18XUB4J3RDvjeCRL/1VbbgAd0RPu08Epy/U1+wR/xRo62H4lSv 7m+BWKGtg+qGo1wjdJ7LHFruJwq/kLFm0iXO8wAICD7ALauJ2ZeQ9sIMxIeCY1Y5 wjFz76CIEEzCyjO10PQoRoFy64SeBr48fN8JOZ7P+iNNb9f7RQ+uMdXkXezrg4Qv hmoMUEZwvm4QG2GRFuJAwzhnTixQkE37jvDgOXpixmhkgPPjcLOqD7CE+i74Y2U+ ZYYRc3KaXHTMv4wF9+6Cq4RkgBfzl8Y2brDIhSpXznYWyj9MHLGjJuWLVZD5uS4P tZ6pek5YhcJWWhOdv5So6LjkuW/w5/R3rAgLCKpzuZcfo36NiE+IwImZ+3uc/Otd DqPc0wfcv78HZUTvHY3+qIbowRERWIvDv/Mhz064QFx+fnRQY02KngM6SKu4vJAM F9RxZXfJXDeTiRRQklWX2BhW3pcJAUTXZVNCTx1FRnzNxfvKDlvxOuZm2UjCPQtf 1VFRCcBS1Fcwv6LI6e1nGBYoJnDxxYX3s0IfQhnJauphPkFMN46eT7MKWEngreqr r27kWejcdG1SLhDf7hYcqIFWZAqXNNuR1eSOxDVENP2uZnbBAMjgQzELPjUJYEeo EizOrHtJ6S+NICieqNgs =5yzx -----END PGP SIGNATURE----- --D6IIOQQv2Iwyp54J--