From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 31 Aug 2015 21:34:49 +0200 From: Christoph Hellwig Subject: Re: [PATCH] dax, pmem: add support for msync Message-ID: <20150831193449.GA27444@lst.de> References: <1441047584-14664-1-git-send-email-ross.zwisler@linux.intel.com> <20150831190619.GA27141@lst.de> <20150831192640.GA15717@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150831192640.GA15717@linux.intel.com> Sender: owner-linux-mm@kvack.org To: Ross Zwisler , Christoph Hellwig , linux-kernel@vger.kernel.org, Alexander Viro , Andrew Morton , Dave Hansen , "H. Peter Anvin" , Hugh Dickins , Ingo Molnar , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Matthew Wilcox , Peter Zijlstra , Thomas Gleixner , x86@kernel.org List-ID: On Mon, Aug 31, 2015 at 01:26:40PM -0600, Ross Zwisler wrote: > > Should this be abstracted by adding a ->msync method? Maybe not > > worth to do for now, but it might be worth to keep that in mind. > > Where would we add the ->msync method? Do you mean to the PMEM API, or > somewhere else? vm_operations_struct would be the most logical choice, with filesystems having a dax-specific instance of that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754158AbbHaTew (ORCPT ); Mon, 31 Aug 2015 15:34:52 -0400 Received: from verein.lst.de ([213.95.11.211]:60558 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753976AbbHaTev (ORCPT ); Mon, 31 Aug 2015 15:34:51 -0400 Date: Mon, 31 Aug 2015 21:34:49 +0200 From: Christoph Hellwig To: Ross Zwisler , Christoph Hellwig , linux-kernel@vger.kernel.org, Alexander Viro , Andrew Morton , Dave Hansen , "H. Peter Anvin" , Hugh Dickins , Ingo Molnar , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@ml01.01.org, Matthew Wilcox , Peter Zijlstra , Thomas Gleixner , x86@kernel.org Subject: Re: [PATCH] dax, pmem: add support for msync Message-ID: <20150831193449.GA27444@lst.de> References: <1441047584-14664-1-git-send-email-ross.zwisler@linux.intel.com> <20150831190619.GA27141@lst.de> <20150831192640.GA15717@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150831192640.GA15717@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 31, 2015 at 01:26:40PM -0600, Ross Zwisler wrote: > > Should this be abstracted by adding a ->msync method? Maybe not > > worth to do for now, but it might be worth to keep that in mind. > > Where would we add the ->msync method? Do you mean to the PMEM API, or > somewhere else? vm_operations_struct would be the most logical choice, with filesystems having a dax-specific instance of that.