From: Martin Jansa <martin.jansa@gmail.com>
To: Alex Franco <alejandro.franco@linux.intel.com>
Cc: david.nystrom@enea.com, clarson@kergoth.com,
bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] Allow bitbake commands starting with do_ v2
Date: Mon, 31 Aug 2015 22:18:22 +0200 [thread overview]
Message-ID: <20150831201822.GA823@jama> (raw)
In-Reply-To: <1441051232-30028-1-git-send-email-alejandro.franco@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]
On Mon, Aug 31, 2015 at 03:00:32PM -0500, Alex Franco wrote:
> The output of "bitbake, -c listtasks pkg" lists tasks with their real names
> (starting with "do_"), but then "bitbake -c do_task" fails, as "do_" always
> gets unconditionally prepended to task names. This patch handles this error
> by always removing "do_" from the beginning of task names when the runqueue
> is being constructed.
>
> [YOCTO #7818]
"v2" belongs to [PATCHv2] (set by subject-prefix), you don't want it to be part of final commit
message, do you?
>
> Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
> ---
> bitbake/lib/bb/runqueue.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
> index 0f99e5a..834992f 100644
> --- a/bitbake/lib/bb/runqueue.py
> +++ b/bitbake/lib/bb/runqueue.py
> @@ -634,6 +634,10 @@ class RunQueueData:
>
> fnid = taskData.build_targets[targetid][0]
> fn = taskData.fn_index[fnid]
> +
> + if target[1].startswith("do_"):
> + target[1] = target[1].replace("do_", "", 1)
> +
> self.target_pairs.append((fn, target[1]))
>
> if fnid in taskData.failed_fnids:
> --
> 2.5.1
>
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
prev parent reply other threads:[~2015-08-31 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 20:00 [PATCH] Allow bitbake commands starting with do_ v2 Alex Franco
2015-08-31 20:16 ` Mark Hatle
2015-08-31 20:18 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831201822.GA823@jama \
--to=martin.jansa@gmail.com \
--cc=alejandro.franco@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=clarson@kergoth.com \
--cc=david.nystrom@enea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.