From: Phil Sutter <phil@nwl.cc>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: tgraf@suug.ch, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
wfg@linux.intel.com, lkp@01.org
Subject: Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads
Date: Tue, 1 Sep 2015 14:46:48 +0200 [thread overview]
Message-ID: <20150901124648.GA27550@orbit.nwl.cc> (raw)
In-Reply-To: <20150901114300.GB12691@gondor.apana.org.au>
On Tue, Sep 01, 2015 at 07:43:00PM +0800, Herbert Xu wrote:
> On Mon, Aug 31, 2015 at 01:00:12PM +0200, Phil Sutter wrote:
> >
> > The variable would be used to track if the worker has failed to allocate
> > memory in background.
> >
> > Since the failing insertion will be retried, subsequent inserts are not
> > necessary unrelated.
>
> If an insertion fails it is never retried. The only thing that is
> retried is the expansion of the table. So I have no idea what
> you are talking about.
This is not an inherent behaviour of the implementation but general
agreement. The insertion may fail non-permanently (returning -EBUSY),
users are expected to handle this by retrying the operation.
Cheers, Phil
next prev parent reply other threads:[~2015-09-01 12:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 10:28 [PATCH 1/3] rhashtable-test: add cond_resched() to thread test Phil Sutter
2015-08-28 10:28 ` [PATCH 2/3] rhashtable-test: retry insert operations in threads Phil Sutter
2015-08-28 11:09 ` Thomas Graf
2015-08-28 11:09 ` Thomas Graf
2015-08-28 11:13 ` Phil Sutter
2015-08-28 13:34 ` Phil Sutter
2015-08-28 22:43 ` Thomas Graf
2015-08-28 22:43 ` Thomas Graf
2015-08-29 9:07 ` Phil Sutter
2015-08-30 7:47 ` Herbert Xu
2015-08-30 7:47 ` Herbert Xu
2015-08-31 11:00 ` Phil Sutter
2015-09-01 11:43 ` Herbert Xu
2015-09-01 11:43 ` Herbert Xu
2015-09-01 12:46 ` Phil Sutter [this message]
2015-09-01 13:00 ` Herbert Xu
2015-09-01 13:00 ` Herbert Xu
2015-09-01 13:40 ` Eric Dumazet
2015-09-01 13:40 ` Eric Dumazet
2015-09-01 13:43 ` Phil Sutter
2015-09-01 13:50 ` Herbert Xu
2015-09-01 13:50 ` Herbert Xu
2015-09-01 13:56 ` Phil Sutter
2015-09-01 14:03 ` Herbert Xu
2015-09-01 14:03 ` Herbert Xu
2015-09-01 14:13 ` Thomas Graf
2015-09-01 14:13 ` Thomas Graf
2015-09-01 14:16 ` Herbert Xu
2015-09-01 14:16 ` Herbert Xu
2015-09-01 14:51 ` Thomas Graf
2015-09-01 14:51 ` Thomas Graf
2015-09-02 2:00 ` Herbert Xu
2015-09-02 2:00 ` Herbert Xu
2015-09-02 7:07 ` Thomas Graf
2015-09-02 7:07 ` Thomas Graf
2015-09-10 8:03 ` Herbert Xu
2015-09-10 8:03 ` Herbert Xu
2015-09-10 10:05 ` Phil Sutter
2015-08-28 10:28 ` [PATCH 3/3] rhashtable-test: calculate max_entries value by default Phil Sutter
2015-08-28 11:11 ` Thomas Graf
2015-08-28 11:11 ` Thomas Graf
2015-08-28 11:03 ` [PATCH 1/3] rhashtable-test: add cond_resched() to thread test Thomas Graf
2015-08-28 11:03 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901124648.GA27550@orbit.nwl.cc \
--to=phil@nwl.cc \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.