From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755473AbbIAOzh (ORCPT ); Tue, 1 Sep 2015 10:55:37 -0400 Received: from mail.kernel.org ([198.145.29.136]:51309 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753960AbbIAOz3 (ORCPT ); Tue, 1 Sep 2015 10:55:29 -0400 Date: Tue, 1 Sep 2015 11:55:25 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Adrian Hunter , Ingo Molnar , linux-kernel@vger.kernel.org, Andy Lutomirski , Masami Hiramatsu , Denys Vlasenko , Peter Zijlstra , Dave Hansen , Qiaowei Ren , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [PATCH 0/4] x86/insn: perf tools: Add a few new x86 instructions Message-ID: <20150901145525.GD29821@kernel.org> References: <1441029522-20235-1-git-send-email-adrian.hunter@intel.com> <20150901085432.GE6315@gmail.com> <55E59734.4080205@intel.com> <20150901135916.GA1978@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150901135916.GA1978@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Sep 01, 2015 at 03:59:16PM +0200, Jiri Olsa escreveu: > On Tue, Sep 01, 2015 at 03:16:52PM +0300, Adrian Hunter wrote: > > On 01/09/15 11:54, Ingo Molnar wrote: > > > it would be nice to add a diff check to the perf build, and (non-fatally) warn > > > during the build if the two versions depart from each other? > > I had a go and came up with this. Arnaldo, Jiri any comments? > > diff --git a/tools/perf/util/intel-pt-decoder/Build b/tools/perf/util/intel-pt-decoder/Build > > + diff -B -I'^#include' util/intel-pt-decoder/insn.h ../../arch/x86/include/asm/insn.h >/dev/null && \ > > + diff -B -I'^#include' util/intel-pt-decoder/inat.h ../../arch/x86/include/asm/inat.h >/dev/null && \ > > + diff -B -I'^#include' util/intel-pt-decoder/inat_types.h ../../arch/x86/include/asm/inat_types.h >/dev/null) \ > > + || echo "Warning: Intel PT: x86 instruction decoder differs from kernel" >&2 ) > > + $(call rule_mkdir) > > + $(call if_changed_dep,cc_o_c) > seems ok, but it might be nicer to have make function for that > so we could use it on other places like rbtree.h That will pose some more hurdles, as there are things like EXPORT_SYMBOL() and RCU stuff that are ok in the kernel sources, but not in the tools/ copy... I.e. fully sharing will put a new burden for kernel developers working on the to-be-shared code, which is something that is not desired. I was ok with, hey, tools/ broke because you're sharing code with the kernel, as probably a tools/ developer would notice that and fix things, but Linus advised against that. - Arnaldo