Re: [PATCH v3 07/11] tmem: Make the uint64_t oid[3] a proper structure: tmem_oid

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Tue, Sep 01, 2015 at 09:54:12AM -0600, Jan Beulich wrote:
> >>> On 01.09.15 at 17:23, <konrad.wilk@oracle.com> wrote:
> > There is only need for the compat layer once I move the 'xen_tmem_oid_t' to
> > the tmem.h header file - and there is where the introduction in xlat.lst is 
> > done:
> > 
> > --- a/xen/include/xlat.lst
> > +++ b/xen/include/xlat.lst
> > @@ -103,6 +103,7 @@
> >  !      sched_poll                      sched.h
> >  ?      sched_remote_shutdown           sched.h
> >  ?      sched_shutdown                  sched.h
> > +?      xen_tmem_oid                    tmem.h
> 
> Looks like your problem is the xen_ prefix here - no other entity has
> it, despite there being a number of examples where the actual type
> uses such a prefix.

Yup! This made it work:


diff --git a/xen/common/compat/tmem_xen.c b/xen/common/compat/tmem_xen.c
index 6bd1ad4..db08005 100644
--- a/xen/common/compat/tmem_xen.c
+++ b/xen/common/compat/tmem_xen.c
@@ -11,9 +11,7 @@
 #include <xen/hypercall.h>
 #include <compat/tmem.h>
 
-#define xen_xen_tmem_oid xen_tmem_oid
-CHECK_xen_tmem_oid;
-#undef xen_xen_tmem_oid
+CHECK_tmem_oid;
 
 /*
  * Local variables:
diff --git a/xen/include/xlat.lst b/xen/include/xlat.lst
index ace1d53..3795059 100644
--- a/xen/include/xlat.lst
+++ b/xen/include/xlat.lst
@@ -103,7 +103,7 @@
 !	sched_poll			sched.h
 ?	sched_remote_shutdown		sched.h
 ?	sched_shutdown			sched.h
-?	xen_tmem_oid			tmem.h
+?	tmem_oid			tmem.h
 !	tmem_op				tmem.h
 ?	t_buf				trace.h
 ?	vcpu_get_physid			vcpu.h

Thank you!
> 
> Jan
>