Re: [Qemu-devel] [PATCH RFC v3 30/32] qapi: New QMP command query-schema for QMP schema introspection

[Michael Roth <mdroth@linux.vnet.ibm.com>]

Quoting Markus Armbruster (2015-08-04 10:58:14)
> Caution, rough edges.
> 
> qapi/introspect.json defines the introspection schema.  It should do
> for uses other than QMP.
> FIXME it's almost entirely devoid of comments.
> 
> The introspection schema does not reflect all the rules and
> restrictions that apply to QAPI schemata.  A valid QAPI schema has an
> introspection value conforming to the introspection schema, but the
> converse is not true.
> 
> Introspection lowers away a number of schema details:
> 
> * The built-in types are declared with their JSON type.
> 
>   TODO Should we map all the integer types to just int?

I don't think we should. If management chooses to handle them in this
generic fashion that's their perogative/problem, but treating all ints
as a single generic type can lead to unexpected results when those values
get passed on to functions expecting, for instance, uint8_t. So QEMU
should do its part to convey this information somehow.