From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
nm@ti.com, khilman@linaro.org, Anand Moon <moon.linux@yahoo.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH V2 Resend 3/5] PM / OPP: Move opp core to its own directory
Date: Tue, 1 Sep 2015 15:51:15 -0700 [thread overview]
Message-ID: <20150901225115.GB21112@codeaurora.org> (raw)
In-Reply-To: <54ff6f4e8fe495d9a859a7a7aa61ac2e79f08551.1441083292.git.viresh.kumar@linaro.org>
On 09/01, Viresh Kumar wrote:
> OPP code is expanding and is already present in multiple directories
> (cpufreq and power). Lets move it to its own directory, to manage it
> better.
>
> This also moves/renames the cpufreq_opp file to cpu.c, as it will
> contain helpers for cpu device. Its not just about cpufreq, other
> frameworks can use OPPs as well.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> diff --git a/drivers/base/power/opp/Makefile b/drivers/base/power/opp/Makefile
> new file mode 100644
> index 000000000000..33c1e18c41a4
> --- /dev/null
> +++ b/drivers/base/power/opp/Makefile
> @@ -0,0 +1,2 @@
> +ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG
It's odd that we use CONFIG_DEBUG_DRIVER here when that's talking
about debugging the driver core. I wonder why this wouldn't be
some OPP specific debug config option instead. But that was
already there before so this topic is for another patch.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-09-01 22:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 4:58 [PATCH V2 Resend 0/5] PM / OPP: Add debugfs support Viresh Kumar
2015-09-01 4:58 ` [PATCH V2 Resend 1/5] PM / OPP: reuse of_parse_phandle() Viresh Kumar
2015-09-01 4:58 ` Viresh Kumar
2015-09-01 22:48 ` Stephen Boyd
2015-09-01 4:58 ` [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_ Viresh Kumar
2015-09-01 4:58 ` Viresh Kumar
2015-09-01 19:03 ` Pavel Machek
2015-09-02 7:22 ` Viresh Kumar
2015-09-02 7:25 ` Viresh Kumar
2015-09-03 0:00 ` Stephen Boyd
2015-09-01 4:58 ` [PATCH V2 Resend 3/5] PM / OPP: Move opp core to its own directory Viresh Kumar
2015-09-01 4:58 ` Viresh Kumar
2015-09-01 22:51 ` Stephen Boyd [this message]
2015-09-02 7:13 ` Viresh Kumar
2015-09-01 4:58 ` [PATCH V2 Resend 4/5] PM / OPP: Move cpu specific code to opp/cpu.c Viresh Kumar
2015-09-01 4:58 ` Viresh Kumar
2015-09-01 4:58 ` [PATCH V2 Resend 5/5] PM / OPP: Add debugfs support Viresh Kumar
2015-09-01 4:58 ` Viresh Kumar
2015-09-01 23:00 ` Stephen Boyd
2015-09-03 1:05 ` [PATCH V2 Resend 0/5] " Rafael J. Wysocki
2015-09-03 4:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901225115.GB21112@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=moon.linux@yahoo.com \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.