From: Brian Norris <computersforpeace@gmail.com>
To: Han Xu <xhnjupt@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Marek Vasut" <marex@denx.de>,
"Joachim Eastwood" <manabian@gmail.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
"Han Xu" <han.xu@freescale.com>
Subject: Re: [RFT PATCH 1/4] mtd: fsl-quadspi: use automatic spi-nor detection
Date: Tue, 1 Sep 2015 16:54:54 -0700 [thread overview]
Message-ID: <20150901235454.GL81844@google.com> (raw)
In-Reply-To: <CA+EcR224fveExjquswAJn9+XZOSRyUA03H8u1tgtHsM-Qvn+tw@mail.gmail.com>
On Tue, Sep 01, 2015 at 06:40:17PM -0500, Han Xu wrote:
> On Thu, Aug 13, 2015 at 5:46 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > We don't really need the flash information from the device tree here.
> > Let's stick with autodetection here instead.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > ---
> > drivers/mtd/spi-nor/fsl-quadspi.c | 8 +-------
> > 1 file changed, 1 insertion(+), 7 deletions(-)
> >
> > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> > index d32b7e04ccca..2a17ec6269ff 100644
> > --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> > @@ -1006,8 +1006,6 @@ static int fsl_qspi_probe(struct platform_device *pdev)
> >
> > /* iterate the subnodes. */
> > for_each_available_child_of_node(dev->of_node, np) {
> > - char modalias[40];
> > -
> > /* skip the holes */
> > if (!q->has_second_chip)
> > i *= 2;
> > @@ -1030,10 +1028,6 @@ static int fsl_qspi_probe(struct platform_device *pdev)
> > nor->prepare = fsl_qspi_prep;
> > nor->unprepare = fsl_qspi_unprep;
> >
> > - ret = of_modalias_node(np, modalias, sizeof(modalias));
> > - if (ret < 0)
> > - goto mutex_failed;
> > -
> > ret = of_property_read_u32(np, "spi-max-frequency",
> > &q->clk_rate);
> > if (ret < 0)
> > @@ -1042,7 +1036,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
> > /* set the chip address for READID */
> > fsl_qspi_set_base_addr(q, nor);
> >
> > - ret = spi_nor_scan(nor, modalias, SPI_NOR_QUAD);
> > + ret = spi_nor_scan(nor, NULL, SPI_NOR_QUAD);
> > if (ret)
> > goto mutex_failed;
> >
>
> Acked-by: Han xu <han.xu@freescale.com>
> Tested-by: Han xu <han.xu@freescale.com>
Thanks, applied to l2-mtd.git/next
next prev parent reply other threads:[~2015-09-01 23:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 22:46 [RFT PATCH 0/4] mtd: spi-nor: code refactoring and layering Brian Norris
2015-08-13 22:46 ` [RFT PATCH 1/4] mtd: fsl-quadspi: use automatic spi-nor detection Brian Norris
2015-08-13 23:09 ` Marek Vasut
2015-08-13 23:24 ` Brian Norris
2015-08-13 23:54 ` Marek Vasut
2015-08-14 5:40 ` Michal Suchanek
2015-08-18 2:56 ` Brian Norris
2015-08-18 3:15 ` Han Xu
2015-08-18 8:09 ` Huang Shijie
2015-09-01 18:41 ` Brian Norris
2015-09-01 23:40 ` Han Xu
2015-09-01 23:54 ` Brian Norris [this message]
2015-08-13 22:46 ` [RFT PATCH 2/4] mtd: spi-nor: assign mtd->priv in spi_nor_scan() Brian Norris
2015-08-14 14:48 ` Joachim Eastwood
2015-08-13 22:46 ` [RFT PATCH 3/4] mtd: spi-nor: add forward declaration for mtd_info Brian Norris
2015-08-14 14:49 ` Joachim Eastwood
2015-08-13 22:46 ` [RFT PATCH 4/4] mtd: spi-nor: embed struct mtd_info within struct spi_nor Brian Norris
2015-08-14 14:52 ` Joachim Eastwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901235454.GL81844@google.com \
--to=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=han.xu@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=manabian@gmail.com \
--cc=marex@denx.de \
--cc=xhnjupt@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.