Re: [PATCH/RFC 05/10] arm64: dts: r8a7795: add clock for EthernetAVB

[Simon Horman <horms@verge.net.au>]

On Thu, Aug 27, 2015 at 01:11:02PM +0200, Geert Uytterhoeven wrote:
> Hi Simon, Mizuguchi-san,
> 
> On Thu, Aug 27, 2015 at 11:24 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >
> > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> > [horms: updated p_clk to s3d4_clk; moved to clock node; updated changelog;
> >         use R8A7795 as prefix for clock defines]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a7795.dtsi  | 11 +++++++++++
> >  include/dt-bindings/clock/r8a7795-clock.h |  1 +
> >  2 files changed, 12 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > index a608eb92a172..0b435d8274e4 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -227,6 +227,16 @@
> >                                         clock-output-names = "hsusb", "ehci0", "ehci1", "ehci2";
> >                                 };
> >
> > +                               mstp8_clks: mstp8_clks@e6150990 {
> > +                                       compatible = "renesas,r8a7795-mstp-clocks",
> > +                                                    "renesas,cpg-mstp-clocks";
> > +                                       reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> > +                                       clocks =  <&s3d4_clk>;
> 
> According to the datasheet, this should be s3d2 on H3.

Thanks.

> > +                                       #clock-cells = <1>;
> > +                                       renesas,clock-indices = <R8A7795_CLK_AVB>;
> 
> The datasheet calls this "EAVB-IF", so I'd go for "R8A7795_CLK_EAVB".

I plan to go with with R8A7795_CLK_ETHERAVB for consistency with the r8a7790.

> 
> > +                                       clock-output-names = "avb";
> > +                               };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>