Re: [PATCH V2] watchdog: Add watchdog device control through sysfs attributes

[Pratyush Anand <panand@redhat.com>]

Hi Guenter,

Thanks for review and explaining it.

On 01/09/2015:08:27:11 PM, Guenter Roeck wrote:
> Playing with it, I see two alternatives (2a/2b), both of which I prefer.

OK..I will make the changes as you prefer. May be I will keep these changes as
1st patch and another patch to add sysfs attributes.

> 
> 1) Move struct class watchdog_class to watchdog_dev.c, and initialize it there.
>    Attach the groups to the .dev_groups variable in watchdog_class.
> 2a) Make watchdog_class global, and use a pointer to it in watchdog_core.c.
>     Use class_register / class_unregister instead of class_create / class_destroy.
> 2b) Make watchdog_class static in watchdog_dev.c. Move its registration and de-registration
>     to watchdog_dev_init() and watchdog_dev_exit(). Again, use class_register
>     and class_unregister.
>     Have watchdog_dev_init return a pointer to watchdog_class (and ERR_PTR on errors).
> 3) Keep the rest of the code in place as-is, specifically keep using device_create()
>    as is in __watchdog_register_device().
> 
> Maybe 1 / 2b / 3 so we don't need to introduce a new global ?

But with 2b, we will still have to move device_create() to
watchdog_dev_register, because it needs watchdog_class. So, are you OK
with that? Else I can implement 2a, if that seems more suitable to you.

~Pratyush