Re: [PATCH 01/15] perf tools: Fix parse_events_add_pmu caller

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Wed, Sep 02, 2015 at 09:56:31AM +0200, Jiri Olsa escreveu:
> Following commit changed parse_events_add_pmu interface:
>   36adec85a86f perf tools: Change parse_events_add_pmu interface
> 
> but forgot to change one caller. Because of lessen compilation
> rules for the bison parser, the compiler did not warn on that.

Humm, wonder what can be done to improve this situation...  No ideas?

Applying to perf/urgent,

Thanks,

- Arnaldo
 
> Link: http://lkml.kernel.org/n/tip-fda5a524tfapmpb85bmaigo2@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/util/parse-events.y | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 591905a02b92..9cd70819c795 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -255,7 +255,7 @@ PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF sep_dc
>  	list_add_tail(&term->list, head);
>  
>  	ALLOC_LIST(list);
> -	ABORT_ON(parse_events_add_pmu(list, &data->idx, "cpu", head));
> +	ABORT_ON(parse_events_add_pmu(data, list, "cpu", head));
>  	parse_events__free_terms(head);
>  	$$ = list;
>  }
> -- 
> 2.4.3