From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: boaz@plexistor.com, kirill.shutemov@linux.intel.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: add ->pfn_mkwrite support for DAX
Date: Thu, 3 Sep 2015 07:34:37 +1000 [thread overview]
Message-ID: <20150902213437.GT3902@dastard> (raw)
In-Reply-To: <20150902051217.GA18906@infradead.org>
On Tue, Sep 01, 2015 at 10:12:17PM -0700, Christoph Hellwig wrote:
> On Wed, Sep 02, 2015 at 11:25:00AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > ->pfn_mkwrite support is needed so that when a page with allocated
> > backing store first takes a write fault the timestamps on the
> > file are updated. THis fixes a generic/080 failure.
>
> Shouldn't you be able to drop the call to xfs_filemap_page_mkwrite from
> xfs_filemap_fault now?
No idea. It hasn't been removed from dax_fault, so I'm not going to
remove it from xfs_filemap_page_mkwrite()...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-09-02 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 1:25 [PATCH] xfs: add ->pfn_mkwrite support for DAX Dave Chinner
2015-09-02 5:12 ` Christoph Hellwig
2015-09-02 21:34 ` Dave Chinner [this message]
2015-09-02 9:23 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902213437.GT3902@dastard \
--to=david@fromorbit.com \
--cc=boaz@plexistor.com \
--cc=hch@infradead.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.