From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Thu, 3 Sep 2015 09:00:28 +0100 Subject: [PATCH] ARM: fix bug which VMALLOC_START is lowwer than 0xf0000000 In-Reply-To: <1441247087-10342-1-git-send-email-ytk.lee@samsung.com> References: <1441247087-10342-1-git-send-email-ytk.lee@samsung.com> Message-ID: <20150903080028.GS21084@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 03, 2015 at 11:24:47AM +0900, Yongtaek Lee wrote: > default value of vmalloc_min was set 0xf0000000 for ARM by commit > 0536bdf3. But actually vmalloc_min is 0xef800000 not 0xf0000000. > > VMALLOC_END - (240 << 20) - VMALLOC_OFFSET) > 0xff000000 - 0x0f000000 - 0x00800000 = 0xef800000 > > In case of 768MB ram without CONFIG_HIGHMEM=y, last 8MB could not be > allocated. Kernel log also print out warning message as below. > "Truncating RAM at 80000000-afffffff to -af7fffff (vmalloc region overlap)." > > Although it could be solved by state "vmalloc=size" in cmdline but i think > it would be better to change default value to 232 from 240. > > Signed-off-by: Yongtaek Lee I fail to see what the problem is here. You're adjusting the size of the vmalloc space to accomodate the size of RAM you have. That's not a bug. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752642AbbICIAi (ORCPT ); Thu, 3 Sep 2015 04:00:38 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:46897 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756AbbICIAh (ORCPT ); Thu, 3 Sep 2015 04:00:37 -0400 Date: Thu, 3 Sep 2015 09:00:28 +0100 From: Russell King - ARM Linux To: Yongtaek Lee Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nicolas Pitre Subject: Re: [PATCH] ARM: fix bug which VMALLOC_START is lowwer than 0xf0000000 Message-ID: <20150903080028.GS21084@n2100.arm.linux.org.uk> References: <1441247087-10342-1-git-send-email-ytk.lee@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441247087-10342-1-git-send-email-ytk.lee@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2015 at 11:24:47AM +0900, Yongtaek Lee wrote: > default value of vmalloc_min was set 0xf0000000 for ARM by commit > 0536bdf3. But actually vmalloc_min is 0xef800000 not 0xf0000000. > > VMALLOC_END - (240 << 20) - VMALLOC_OFFSET) > 0xff000000 - 0x0f000000 - 0x00800000 = 0xef800000 > > In case of 768MB ram without CONFIG_HIGHMEM=y, last 8MB could not be > allocated. Kernel log also print out warning message as below. > "Truncating RAM at 80000000-afffffff to -af7fffff (vmalloc region overlap)." > > Although it could be solved by state "vmalloc=size" in cmdline but i think > it would be better to change default value to 232 from 240. > > Signed-off-by: Yongtaek Lee I fail to see what the problem is here. You're adjusting the size of the vmalloc space to accomodate the size of RAM you have. That's not a bug. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.