From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: Future proof uncore_init.
Date: Thu, 3 Sep 2015 14:06:24 +0300 [thread overview]
Message-ID: <20150903110624.GT29811@intel.com> (raw)
In-Reply-To: <1441232366-4876-2-git-send-email-rodrigo.vivi@intel.com>
On Wed, Sep 02, 2015 at 03:19:25PM -0700, Rodrigo Vivi wrote:
> Unless future specs tells otherwise we can assume future gens
> inherit some stuff from the previous so let's handle
> missed cases when we know tehy should't be there and assume
> default equals newest one.
>
> No functional changes.
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index dec20d6..e633d36 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -1202,8 +1202,6 @@ void intel_uncore_init(struct drm_device *dev)
>
> switch (INTEL_INFO(dev)->gen) {
> default:
> - MISSING_CASE(INTEL_INFO(dev)->gen);
> - return;
> case 9:
> ASSIGN_WRITE_MMIO_VFUNCS(gen9);
> ASSIGN_READ_MMIO_VFUNCS(gen9);
> @@ -1242,6 +1240,10 @@ void intel_uncore_init(struct drm_device *dev)
> ASSIGN_WRITE_MMIO_VFUNCS(gen2);
> ASSIGN_READ_MMIO_VFUNCS(gen2);
> break;
> + case 1:
> + case 0:
> + MISSING_CASE(INTEL_INFO(dev)->gen);
> + return;
Seems pointless, and confusing since we don't support gen0-1.
> }
>
> if (intel_vgpu_active(dev)) {
> --
> 2.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-03 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 22:19 [PATCH 1/3] drm/i915: Future proof interrupt handler Rodrigo Vivi
2015-09-02 22:19 ` [PATCH 2/3] drm/i915: Future proof uncore_init Rodrigo Vivi
2015-09-03 11:06 ` Ville Syrjälä [this message]
2015-09-03 21:38 ` [PATCH] " Rodrigo Vivi
2015-09-04 8:10 ` Daniel Vetter
2015-09-02 22:19 ` [PATCH 3/3] drm/i915: Future proof panel fitter Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903110624.GT29811@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.