From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Wood <thomas.wood@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/2] tests/gem_storedw_loop: skip on gen6 bsd
Date: Fri, 4 Sep 2015 10:15:27 +0200 [thread overview]
Message-ID: <20150904081527.GL22430@phenom.ffwll.local> (raw)
In-Reply-To: <1441271128-12165-1-git-send-email-thomas.wood@intel.com>
On Thu, Sep 03, 2015 at 10:05:27AM +0100, Thomas Wood wrote:
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
Bit more commit message would be good, just copypaste the debug output ;-)
lgtm otherwise on the patch series.
-Daniel
> ---
> tests/gem_storedw_loop.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c
> index 2263397..1bb276e 100644
> --- a/tests/gem_storedw_loop.c
> +++ b/tests/gem_storedw_loop.c
> @@ -144,6 +144,14 @@ struct ring {
> { "vebox", I915_EXEC_VEBOX },
> };
>
> +static void
> +check_test_requirements(int fd, int ringid)
> +{
> + gem_require_ring(fd, ringid);
> + igt_skip_on_f(intel_gen(devid) == 6 && ringid == I915_EXEC_BSD,
> + "MI_STORE_DATA broken on gen6 bsd\n");
> +}
> +
> igt_main
> {
> int fd, i;
> @@ -166,13 +174,14 @@ igt_main
> }
>
> for (i = 0; i < ARRAY_SIZE(rings); i++) {
> +
> igt_subtest_f("basic-%s", rings[i].name) {
> - gem_require_ring(fd, rings[i].id);
> + check_test_requirements(fd, rings[i].id);
> store_test(rings[i].id, 16*1024);
> }
>
> igt_subtest_f("long-%s", rings[i].name) {
> - gem_require_ring(fd, rings[i].id);
> + check_test_requirements(fd, rings[i].id);
> store_test(rings[i].id, 1024*1024);
> }
> }
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-04 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 9:05 [PATCH i-g-t 1/2] tests/gem_storedw_loop: skip on gen6 bsd Thomas Wood
2015-09-03 9:05 ` [PATCH i-g-t 2/2] tests/gem_storedw_loop: remove redundant ppgtt check Thomas Wood
2015-09-04 8:15 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904081527.GL22430@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.