All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serge Hallyn <serge.hallyn@ubuntu.com>
To: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 1/1] vl.c: don't try to insert malloc tracepoints on newer glib
Date: Fri, 4 Sep 2015 17:58:40 +0000	[thread overview]
Message-ID: <20150904175840.GA30773@ubuntumail> (raw)

Because it has deprecated it with commit
3be6ed60aa58095691bd697344765e715a327fc1.  This prevents the warning

(process:3535): GLib-WARNING **: /build/glib2.0-3tdlHy/glib2.0-2.45.6/./glib/gmem.c:482: custom memory allocation vtable not supported

as reported at https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/1491972

(thanks danpb for the suggestion)

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
---
 vl.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/vl.c b/vl.c
index 584ca88..cab9425 100644
--- a/vl.c
+++ b/vl.c
@@ -2719,6 +2719,7 @@ static const QEMUOption *lookup_opt(int argc, char **argv,
     return popt;
 }
 
+#if ! GLIB_CHECK_VERSION(2, 44, 0)
 static gpointer malloc_and_trace(gsize n_bytes)
 {
     void *ptr = malloc(n_bytes);
@@ -2738,6 +2739,7 @@ static void free_and_trace(gpointer mem)
     trace_g_free(mem);
     free(mem);
 }
+#endif
 
 static int machine_set_property(void *opaque,
                                 const char *name, const char *value,
@@ -2966,11 +2968,13 @@ int main(int argc, char **argv, char **envp)
     bool userconfig = true;
     const char *log_mask = NULL;
     const char *log_file = NULL;
+#if ! GLIB_CHECK_VERSION(2, 44, 0)
     GMemVTable mem_trace = {
         .malloc = malloc_and_trace,
         .realloc = realloc_and_trace,
         .free = free_and_trace,
     };
+#endif
     const char *trace_events = NULL;
     const char *trace_file = NULL;
     ram_addr_t maxram_size;
@@ -2986,7 +2990,9 @@ int main(int argc, char **argv, char **envp)
     error_set_progname(argv[0]);
     qemu_init_exec_dir(argv[0]);
 
+#if ! GLIB_CHECK_VERSION(2, 44, 0)
     g_mem_set_vtable(&mem_trace);
+#endif
 
     module_call_init(MODULE_INIT_QOM);
 
-- 
2.5.0

             reply	other threads:[~2015-09-04 17:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 17:58 Serge Hallyn [this message]
2015-09-04 18:11 ` [Qemu-devel] [PATCH 1/1] vl.c: don't try to insert malloc tracepoints on newer glib Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150904175840.GA30773@ubuntumail \
    --to=serge.hallyn@ubuntu.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.