All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mike Dupuis <mike.dupuis.0@gmail.com>
Cc: gregkh@suse.de, hamohammed.sa@gmail.com, gdonald@gmail.com,
	mahfouz.saif.elyazal@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl18192u: fix style issues in ieee80211_softmac_wx.c
Date: Fri, 4 Sep 2015 18:06:43 -0700	[thread overview]
Message-ID: <20150905010643.GA2860@kroah.com> (raw)
In-Reply-To: <1441407606-7951-1-git-send-email-mike.dupuis.0@gmail.com>

On Fri, Sep 04, 2015 at 11:00:06PM +0000, Mike Dupuis wrote:
> This is a patch to the ieee80211_softmac_wx.c file that corrects several
>  checkpatch.pl warnings and errors.
> Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>

You need a blank line before the signed-off-by line.

Also, please break this up into multiple patches, each one only doing
one type of cleanup.  As it is, I can't take it, sorry.

thanks,

greg k-h

      reply	other threads:[~2015-09-05  1:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 23:00 [PATCH] Staging: rtl18192u: fix style issues in ieee80211_softmac_wx.c Mike Dupuis
2015-09-05  1:06 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150905010643.GA2860@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gdonald@gmail.com \
    --cc=gregkh@suse.de \
    --cc=hamohammed.sa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahfouz.saif.elyazal@gmail.com \
    --cc=mike.dupuis.0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.