All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: configure STATUS_LED_BOOT
Date: Sat, 5 Sep 2015 15:11:17 +0200	[thread overview]
Message-ID: <201509051511.17576.marex@denx.de> (raw)
In-Reply-To: <1441458242-2754-1-git-send-email-thomas@wytron.com.tw>

On Saturday, September 05, 2015 at 03:04:02 PM, Thomas Chou wrote:
> Define STATUS_LED_BOOT. So the boot LED will be initialized
> in board_init_r(), and show the boot progress.
> 
> Though the boot LED is set to blinking in board_init_r(),
> only the powerpc and nios2 really support blinking. All other
> archs just turn the LED on and can not blink.
> 
> After the commit "nios2: Switch to generic timer", with the
> removal of call to status_led_tick(), nios2 can not blink LED.
> But it doesn't really matter, because U-Boot usually runs a very
> short time. It should be enough to turn boot LED on and off
> during boot process.
> 
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
>  include/configs/nios2-generic.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/nios2-generic.h
> b/include/configs/nios2-generic.h index 10f9a34..66ad2f0 100644
> --- a/include/configs/nios2-generic.h
> +++ b/include/configs/nios2-generic.h
> @@ -58,8 +58,9 @@
>  #define LED_PIO_RSTVAL			0xff
> 
>  #define STATUS_LED_BIT			0	/* Bit-0 on GPIO */
> -#define STATUS_LED_STATE		1	/* Blinking */
> +#define STATUS_LED_STATE		STATUS_LED_ON
>  #define STATUS_LED_PERIOD	(CONFIG_SYS_HZ / 2)	/* 500 msec */
> +#define STATUS_LED_BOOT			STATUS_LED_BIT
> 
>  /*
>   * BOOTP options

Idea: Maybe you can add a __weak hook into the generic timer code to
blink the LED ?

Best regards,
Marek Vasut

  reply	other threads:[~2015-09-05 13:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04  9:51 [U-Boot] [PATCH 1/2] nios2: Switch to generic timer Marek Vasut
2015-09-04  9:51 ` [U-Boot] [PATCH 2/2] nios2: Split timer code into timer.c Marek Vasut
2015-09-07  8:00   ` Thomas Chou
2015-09-04 13:33 ` [U-Boot] [PATCH 1/2] nios2: Switch to generic timer Thomas Chou
2015-09-04 14:08   ` Marek Vasut
2015-09-05  0:10     ` Thomas Chou
2015-09-07 12:33       ` Marek Vasut
2015-09-05 13:04     ` [U-Boot] [PATCH] nios2: configure STATUS_LED_BOOT Thomas Chou
2015-09-05 13:11       ` Marek Vasut [this message]
2015-09-06 11:35         ` Thomas Chou
2015-09-06 11:56           ` Marek Vasut
2015-09-15  8:39       ` Thomas Chou
2015-09-07  1:10     ` [U-Boot] [PATCH 1/2] nios2: Switch to generic timer Thomas Chou
2015-09-07  9:32       ` Marek Vasut
2015-09-07 11:15         ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201509051511.17576.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.